PokemonBDSP: MenuDetector sees past NEW tags; ShortDialogDetector accepts a long first line by dayfine · Pull Request #152 · dayfine/Arduino-Source

dayfine · 2026-11-02T00:07:53Z

Depends on #129 (base bdsp/walk-v4); the diff shows only this PR's change. Upstream copy: bdsp/detectors-upstream (dc884fd), the same change folded into one commit off upstream main; the four detector files are byte-identical to this branch, only the test registration sits in upstream's list.

BDSP's MenuDetector and ShortDialogDetector miss screens a new-game run goes through; this fixes both and adds image tests.

ShortDialogDetector missed dialogue whose long first line covers the small white box it checks at the right end (Rowan's "Now, go on, and leap into the world of Pokemon!"), so the program kept pressing X. It keeps the old check and also accepts the box's right end below the first line, so every screen it accepted before is still accepted.
MenuDetector's columns start a little further right (0.160 to 0.166), in the gap after each icon: with a NEW tag on TOWN MAP the second column took the edge of the tag and the menu went unseen.
New image tests for both (add_tests_DialogDetector, add_tests_MenuDetector): the new game's BAG/OPTIONS menu, menus with one and three NEW tags, dialogue with a long first line, a "???" name tab, and negatives (HOME, overworlds, dialogue, cloud shadows). MenuDetector runs with both skip_new_banner settings.

The screenshots are in CommandLineTests (PokemonBDSP/DialogDetector, PokemonBDSP/MenuDetector), which needs to merge first.

Testing

PokemonBDSP::MenuDetector (20 cases) and PokemonBDSP::ShortDialogDetector (6) pass with those screenshots checked out.
The screenshots come from new-game, Jubilife and Floaroma runs on a Switch through a 1080p capture card, where both fixes were used.

🤖 Generated with Claude Code

https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

… menu and long first lines (behavior change) Both detectors keep their old check and accept one more case, so every frame they accepted before is still accepted; they only stop missing two real screens: - MenuDetector: a new game's menu has a "NEW" tag above the OPTIONS icon that breaks the top of the third white column. If the five columns are not white from the top, it now also accepts them white from below the tags (y = 0.170), still requiring the existing cross check. - ShortDialogDetector: a long first line (Rowan's "Now, go on, and leap into the world of Pokemon!") covers the right-end white box. If that box is not white, it now also accepts the box's right end below the first line. This changes what existing BDSP programs see for these screens. The screenshots (positives and negatives) are registered per file from CommandLineTests' PokemonBDSP/MenuDetector and PokemonBDSP/DialogDetector. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

dayfine · 2026-11-02T00:10:58Z

+//  Whether the five columns between the icons are white from `top` down.
+static bool stripes_white(const ImageViewRGB32& screen, double top){
+    for (size_t index = 0; index < 5; index++){
+        const ImageFloatBox stripe(0.160 + 0.166 * (double)index, top, 0.015, STRIPE_BOTTOM - top);


dedup with menu_stripe

Done: MenuDetector is back to its old code; the new game's menu uses MenuDetector(color, true) (skip_new_banner), and the screenshot tests run both settings: the new-game menu is found only with skip_new_banner, and the negatives are negative either way.

dayfine · 2026-11-02T00:11:43Z

+void add_tests_DialogDetector(UnitTestDatabase& database){
+    database.add<Test_ShortDialogDetector>("PokemonBDSP/DialogDetector/IntroRowanNameTab_True.png", true);
+    database.add<Test_ShortDialogDetector>("PokemonBDSP/DialogDetector/IntroRowanNoArrow_True.png", true);
+}


can we get another one here that's "regular"?

Added IntroRowanShortLine_True.png (dayfine/CommandLineTests#1): a normal box with one short line that the old right-end check already accepts. It is still an intro frame; an overworld one needs a console capture if you want that too.

…_new_banner Review: MenuDetector(color, skip_new_banner = true) already checks the columns from below the "NEW" tags, which is the new game's menu. So MenuDetector goes back to its old code, and this PR changes only ShortDialogDetector's behavior. The screenshot tests now run both settings: the new game's menu is found with skip_new_banner and missed without it; the negatives are negative either way. ShortDialogDetector also gets an ordinary short-line box (Rowan's "Barry, is it?") as a positive next to the two long-first-line screens. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

MenuDetector keeps its old check (review on #152); the callers here pass skip_new_banner instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

MenuDetector keeps its old check (review on #152); NewGame and Settings pass skip_new_banner instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

…s-v4

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

In Jubilife after the Town Map, the second column took the edge of the NEW tag on TOWN MAP, so the menu went unseen and the checkpoint save fell back to blind presses (r65). Each column now starts a little further right, in the clear gap after an icon; the new game's menu and the Jubilife menu are found with either setting, and the negatives stay negative. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

A menu with three NEW tags, a "???" name tab in Jubilife's plaza, a one-line box with no tab, and cloud shadows over Floaroma as negatives. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

dayfine · 2026-11-02T20:26:26Z

Screenshots are upstream now: PokemonAutomation/CommandLineTests#42.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

…rs-v4

…s-v4

dayfine mentioned this pull request Nov 2, 2026

BDSP AutoStory v4: game actions, battles and their detectors #148

Draft

dayfine commented Nov 2, 2026

View reviewed changes

dayfine changed the title ~~BDSP MenuDetector and ShortDialogDetector: also detect the new game's menu and long first lines (behavior change)~~ BDSP ShortDialogDetector: also detect dialogue whose long first line covers the right end (behavior change) Nov 2, 2026

dayfine and others added 23 commits November 1, 2026 17:20

Merge remote-tracking branch 'origin/bdsp/walk-v4' into bdsp/detector…

5059026

…s-v4

Merge bdsp/walk-v4 into bdsp/detectors-v4

2b44bfe

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

Merge bdsp/walk-v4 into bdsp/detectors-v4

cc96587

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

Merge bdsp/walk-v4 into bdsp/detectors-v4

a947b3d

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

Merge bdsp/walk-v4 into bdsp/detectors-v4

25068d0

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

Merge bdsp/walk-v4 forward

c20de26

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

Merge bdsp/nav-v4 forward

6bafbb4

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

Merge bdsp/nav-v4 forward

15100a0

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

Merge the BDSP chain forward

4f6d3d2

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

Merge the BDSP chain forward

28d6105

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

Merge the BDSP chain forward

451cfaf

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

Merge the BDSP chain forward

6195ebc

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

Merge the BDSP chain forward

cddc4a8

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

Merge origin/bdsp/walk-v4 into bdsp/detectors-v4

b05be8a

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

Merge origin/bdsp/walk-v4 into bdsp/detectors-v4

41cfcf1

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

Merge origin/bdsp/walk-v4 into bdsp/detectors-v4

f85bad6

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

Merge origin/bdsp/walk-v4 into bdsp/detectors-v4

a46a54f

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

Merge origin/bdsp/walk-v4 into bdsp/detectors-v4

3934be6

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

Merge bdsp/walk-v4 into bdsp/detectors-v4

25f75b7

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

Merge bdsp/walk-v4 into bdsp/detectors-v4

81d410d

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

Merge origin/bdsp/walk-v4 into bdsp/detectors-v4

99f22ff

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

dayfine added 2 commits November 2, 2026 07:17

Merge bdsp/walk-v4 into bdsp/detectors-v4

13a56e1

Merge bdsp/maps-v4 (coord events) into bdsp/detectors-v4

843d063

dayfine changed the title ~~BDSP ShortDialogDetector: also detect dialogue whose long first line covers the right end (behavior change)~~ BDSP MenuDetector and ShortDialogDetector: see the menu past NEW tags and dialogue with a long first line (behavior change) Nov 2, 2026

dayfine changed the title ~~BDSP MenuDetector and ShortDialogDetector: see the menu past NEW tags and dialogue with a long first line (behavior change)~~ PokemonBDSP: MenuDetector sees past NEW tags; ShortDialogDetector accepts a long first line Nov 2, 2026

This was referenced Nov 2, 2026

PokemonBDSP: DialogDetector and MenuDetector test screens PokemonAutomation/CommandLineTests#42

Open

PokemonBDSP: DialogDetector and MenuDetector test screens dayfine/CommandLineTests#1

Closed

dayfine and others added 2 commits November 2, 2026 12:58

Merge bdsp/walk-v4 into bdsp/detectors-v4

0d4d23e

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

Merge bdsp/walk-v4 (b22e947: verify mode from #122) into bdsp/detecto…

139d483

…rs-v4

dayfine added this pull request to stack #230 November 5, 2026 18:39

dayfine added 3 commits November 5, 2026 12:19

Merge commit '89f673f74988cea2333e7dd157136f3aa5f39f0e' into HEAD

f5a3c42

Merge remote-tracking branch 'origin/bdsp/walk-v4' into bdsp/detector…

6251b06

…s-v4

BDSP MenuDetector: label namespace closing braces

1b23b0c

Navigation Menu

Repository navigation

PokemonBDSP: MenuDetector sees past NEW tags; ShortDialogDetector accepts a long first line - #152

PokemonBDSP: MenuDetector sees past NEW tags; ShortDialogDetector accepts a long first line#152
dayfine wants to merge 32 commits into
bdsp/walk-v4from
bdsp/detectors-v4

dayfine commented Nov 2, 2026 •

edited

Loading

Uh oh!

dayfine Nov 2, 2026

Uh oh!

dayfine Nov 2, 2026

Uh oh!

dayfine Nov 2, 2026

Uh oh!

dayfine Nov 2, 2026

Uh oh!

dayfine commented Nov 2, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

dayfine commented Nov 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Testing

Uh oh!

dayfine Nov 2, 2026

Choose a reason for hiding this comment

Uh oh!

dayfine Nov 2, 2026

Choose a reason for hiding this comment

Uh oh!

dayfine Nov 2, 2026

Choose a reason for hiding this comment

Uh oh!

dayfine Nov 2, 2026

Choose a reason for hiding this comment

Uh oh!

dayfine commented Nov 2, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

dayfine commented Nov 2, 2026 •

edited

Loading