Conversation
Pituivan
force-pushed
the
fix/tag-directions
branch
from
September 11, 2026 23:35
10a0acf to
75f64e6
Compare
RobLoach
suggested changes
Sep 12, 2026
RobLoach
left a comment
Contributor
There was a problem hiding this comment.
I think this makes sense. You could likely go further and support backwards compatibility by adding a couple #defines too.
Author
|
Good idea! I'm going to sleep but I'll do that tomorrow. |
RobLoach
reviewed
Sep 15, 2026
| ASE_ANIMATION_DIRECTION_PINGPONG_REVERSE, | ||
| } ase_animation_direction_t; | ||
|
|
||
| struct ase_tag_t |
Contributor
There was a problem hiding this comment.
Should look something like this....
Suggested change
| struct ase_tag_t | |
| /* Backwards compatibility */ | |
| #define ASE_ANIMATION_DIRECTION_FORWARDS ASE_ANIMATION_DIRECTION_FORWARD | |
| #define ASE_ANIMATION_DIRECTION_BACKWORDS ASE_ANIMATION_DIRECTION_REVERSE | |
| struct ase_tag_t |
Author
There was a problem hiding this comment.
Sorry if I'm not implementing it right ahead! After a bad Arch update, my system decided to stop booting lol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know if you will accept this since this would break API compatibility, but I wanted to at least fork this for my project because I find the direction enum constants too misleading, since there is one option missing and two of the existing ones have typos.
Basically this PR updates the enum to match the official options in Aseprite program.
ASE_ANIMATION_DIRECTION_FORWARDStoASE_ANIMATION_DIRECTION_FORWARD.ASE_ANIMATION_DIRECTION_BACKWORDStoASE_ANIMATION_DIRECTION_REVERSE.ASE_ANIMATION_DIRECTION_PINGPONG_REVERSE.