Skip to content

Rename ase_animation_direction_t enum values to match Aseprite's naming convention - #444

Open
Pituivan wants to merge 3 commits into
RandyGaul:masterfrom
Pituivan:fix/tag-directions
Open

Pituivan wants to merge 3 commits into
RandyGaul:masterfrom
Pituivan:fix/tag-directions

Conversation

@Pituivan

@Pituivan Pituivan commented Sep 11, 2026

Copy link
Copy Markdown

I don't know if you will accept this since this would break API compatibility, but I wanted to at least fork this for my project because I find the direction enum constants too misleading, since there is one option missing and two of the existing ones have typos.

Basically this PR updates the enum to match the official options in Aseprite program.

  • Renames ASE_ANIMATION_DIRECTION_FORWARDS to ASE_ANIMATION_DIRECTION_FORWARD.
  • Renames ASE_ANIMATION_DIRECTION_BACKWORDS to ASE_ANIMATION_DIRECTION_REVERSE.
  • Adds enum value ASE_ANIMATION_DIRECTION_PINGPONG_REVERSE.
image

@RobLoach RobLoach left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense. You could likely go further and support backwards compatibility by adding a couple #defines too.

@Pituivan

Pituivan commented Sep 12, 2026

Copy link
Copy Markdown
Author

Good idea! I'm going to sleep but I'll do that tomorrow.

Comment thread cute_aseprite.h
ASE_ANIMATION_DIRECTION_PINGPONG_REVERSE,
} ase_animation_direction_t;

struct ase_tag_t

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should look something like this....

Suggested change
struct ase_tag_t
/* Backwards compatibility */
#define ASE_ANIMATION_DIRECTION_FORWARDS ASE_ANIMATION_DIRECTION_FORWARD
#define ASE_ANIMATION_DIRECTION_BACKWORDS ASE_ANIMATION_DIRECTION_REVERSE
struct ase_tag_t

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry if I'm not implementing it right ahead! After a bad Arch update, my system decided to stop booting lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[cute_aseprite] Missing tag direction [cute_aseprite] Typo in Tag Direction enum value name

2 participants