Repository navigation
feat: add ITEM_MEDIA_SIZE for ItemMedia avatars - #42830
juliajforesti wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
WalkthroughThe UI avatar package adds a union of three list density names and maps each name to an avatar size. The package entry point exports the mapping and its type. ChangesAvatar media sizes
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Feature Suggested labels: Merge Risk: ⚪ Minimal · up to
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #42830 +/- ##
========================================
Coverage 70.48% 70.48%
========================================
Files 5413 5413
Lines 229630 229630
Branches 41749 41701 -48
========================================
+ Hits 161846 161860 +14
+ Misses 62448 62432 -16
- Partials 5336 5338 +2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Pull request was closed
Proposed changes (including videos or screenshots)
Adds
ITEM_MEDIA_SIZEto@rocket.chat/ui-avatar: the avatar size anItemMediaholds at each list density (condensed,medium,extended), matching the sidebar view modes. Lists migrating toItemsize their avatars with it instead of hardcodingx20/x28/x36.Issue(s)
Part of the
Itemmigration. Used by #42818, #42819, #42820 and #42832, which carry this commit at the bottom until it lands.Further comments
No consumer yet in this PR; no changeset, since
@rocket.chat/ui-avataris private.🤖 Generated with Claude Code
Summary by CodeRabbit