chore: version packages - #625
Conversation
Build ReportPlease note:
|
6dc6f9a to
ea74b02
Compare
jacob-kreyenbuehl
left a comment
There was a problem hiding this comment.
Reviewed the version bumps. They look correct.
@sap-devx/feature-toggle-node2.1.0 to 2.1.1 (patch)inquirer-guipackages 3.4.13 to 3.5.0 (minor)
But the PR also carries 5 files that are build output, not part of a version bump:
projects/task-explorer/packages/tasks_panel/LICENSE(copied bylegal-copyat build time)projects/task-explorer/packages/tasks_panel/dummy/main.js(webpack output, entrysrc/dummy.jstodummy/)projects/vscode-webview-rpc-lib/tsconfig.browser.tsbuildinfoprojects/vscode-webview-rpc-lib/tsconfig.ext.tsbuildinfoprojects/vscode-webview-rpc-lib/tsconfig.test.tsbuildinfo
Why this happens: release.yml runs pnpm run ci (full build) before the changesets version step, and changesets/action commits the working tree. These paths are not gitignored, so the build output leaks in.
The tsbuildinfo files are machine specific. They hold absolute runner paths, so they should not be committed.
No earlier version PR had these files, so this is new.
Suggestion:
- Add
.gitignorerules so these stop leaking, for example**/tsconfig.*.tsbuildinfoand the task-explorerdummy/output. Or clean build output before the version step. - Regenerate the version PR after the
.gitignorefix so it only contains the version bumps and changelogs.
ea74b02 to
2b80e7f
Compare
5fb237b to
e99efc4
Compare
e99efc4 to
d74592d
Compare
jacob-kreyenbuehl
left a comment
There was a problem hiding this comment.
Reviewed the generated version bumps against the pending changesets. All as expected:
- @sap/cf-tools 3.3.1 to 3.3.2 (patch)
- @sap-devx/feature-toggle-node 2.1.0 to 2.1.1 (patch)
- the 10 inquirer-gui group packages 3.4.13 to 3.5.0 (minor, locked together as configured)
The three pending changesets are consumed by this PR and no source files are touched. The added task-explorer/packages/tasks_panel/LICENSE comes from the build legal-copy step, and other packages track their own LICENSE too, so it is expected.
One sequencing note: the code-snippet changeset PR (#630) is not merged yet, so merging this now would publish without it. Merge #630 first and the bot will refresh this PR to include code-snippet-types.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@sap-devx/inquirer-gui@3.5.0
Minor Changes
@sap/cf-tools@3.3.2
Patch Changes
@sap/cf-toolsintoapp-studio-toolkit.@sap-devx/feature-toggle-node@2.1.1
Patch Changes
@sap-devx/inquirer-gui-file-browser-plugin@3.5.0
Patch Changes
@sap-devx/inquirer-gui-folder-browser-plugin@3.5.0
Patch Changes
@sap-devx/inquirer-gui-login-plugin@3.5.0
Patch Changes
@sap-devx/inquirer-gui-auto-complete-plugin@3.5.0
@sap-devx/controls-navigator@3.5.0
@sap-devx/inquirer-gui-label-plugin@3.5.0
@sap-devx/inquirer-gui-radio-plugin@3.5.0
@sap-devx/inquirer-gui-single-checkbox-plugin@3.5.0
@sap-devx/inquirer-gui-tiles-plugin@3.5.0