[HarryCordewener]

🤖 Generated with Claude Code

https://claude.ai/code/session_01Rqqt7WGskvSsoRXvKMqybx

Summary

A pipeline from raw server output to what a client draws: decode (ANSI/VT, OSC, MXP, Pueblo, Kitty/iTerm2/sixel pictures) → MarkupText lines → render for an output, degraded to its OutputCapabilities.

• Core MarkupString.Decoding: VT tokenizer (DEC state machine), DecoderRegistry of plugins (handlers newest first, false passes on), Decoder per connection, DecodeContext with pens and elements, overwrite on CR/BS/erase, line limits, events, ClientIdentity/ClientAnswers/MTTS, TagScanner and TagSyntax for tag protocols.
• Core MarkupString.Display: OutputCapabilities, DisplayStyle, DisplayRegistry with contributors, SpanRenderer (spans, CSS, classes), CellRenderer (wide chars, tabs, wrap, picture cells, hit testing). Colours are reduced to the nearest of 16 or 256 (redmean, through the IColorResolver) at Standard/Xterm256. New core markups CommandMenuMarkup, HighlightMarkup, LinkGroupMarkup (becomes Interaction.Group); PictureRow.FirstColumn.
• Ansi: WithVt() (SGR with colon subparameters, C0, DEC graphics, OSC 8 with id/68/0-2/4/10-12/52/104/110-112, DA1, XTVERSION, 14/16/18t, DSR; CSI 6 n off by default), WithPictures() with PNG and sixel decoders, Kitty animation frames (a=f, a=a), a PictureStore per connection over an injectable IPictureCache (MemoryPictureCache by default, shareable across connections so a picture is decoded once), moving pictures given as GIF, AnsiStyles contributor, profile ↔ capability conversion, AnsiStyle.Concealed.
• Mxp: WithMxp() decoder (line modes, open/secure tags, SEND menus and prompts, custom elements, entities, VERSION/SUPPORT). Mxp now references Ansi.
• Pueblo: WithPueblo() decoder (mudtext/HTML modes, links, sounds, panes).
• Injection seams (no new dependencies): IDecoderFactory (a DecoderRegistry), IStyleResolver (a DisplayRegistry; the renderers take it), IUrlPolicy with UrlPolicy.Safe/WithSchemes asked by decoders (DecoderOptions.Links), display (DisplayOptions.Links), every writer (MarkupRegistry.WithLinks) and HtmlTagPolicy.Links; decode diagnostics on the MarkupString.Decoding meter via an optional IMeterFactory, and as DecodeDiagnostics.Dropped.
• New package MarkupString.Extensions.DependencyInjection: AddMarkupString() registers the registries, shared picture cache, decoder factory, display defaults and link policy; BindConfiguration() binds MarkupStringOptions with the source-generated binder; UsePictureCache<T>()/UseUrlPolicy<T>() swap implementations; drops are logged at debug level through the host's ILoggerFactory (source-generated LoggerMessage).
• Round trips tested: what the ANSI writer sends for Kitty placeholders (still and moving), iTerm2 and sixel reads back to the same picture rows, pixels and frame times; MXP and Pueblo writer output reads back to the same markup.
• Docs: docs/decoding.md, docs/display.md, docs/dependency-injection.md, docs/formats.md, README tables, package READMEs, CHANGELOG. The design and plan docs were removed.

Test plan

• dotnet run --project MarkupString.Tests: 1524 passing.
• Release build of the solution with PublicAPI analyzers and format verification: clean.
• dotnet publish MarkupString.AotSmoke -r linux-x64 with decoding and DI (configuration binding) sections: no IL warnings, binary prints ok.
• dotnet pack of the new package succeeds.

Known limits

• Kitty frame composing (a=c) is not read; playing/stopping (s, v) is left to the client.
• JPEG/GIF/WebP from iTerm2 are kept as files without pixels (browser only).

Summary by CodeRabbit

• New Features
  • Added terminal-output decoding for VT controls, styling, links, and replies, plus MXP and Pueblo content.
  • Added Kitty, iTerm2, and sixel image support, with picture caching and animated-frame handling.
  • Added output-aware rendering for spans and cell grids, including ANSI styles and concealed text.
  • Added configurable URL policies and dependency-injection setup for decoding, display, and picture settings.
• Documentation
  • Added guides for decoding, display rendering, and dependency-injection configuration.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request adds incremental terminal decoding, display rendering, picture decoding, MXP and Pueblo protocol support, configurable link policies, and dependency-injection registration. It also adds tests, API declarations, documentation, and package integration.

Changes

Terminal decoding and rendering

Layer / File(s)	Summary
Decoder and tokenizer foundation MarkupString/Decoding/*, MarkupString.Tests/Decoding/VtTokenizerTests.cs, docs/decoding.md	Adds decoder registries, per-connection decoding, VT tokenization, tag scanning and parsing, line editing, events, and diagnostics.
Display models and renderers MarkupString/Display/*, MarkupString/Elements/*, MarkupString.Tests/Decoding/DisplayTests.cs, docs/display.md	Adds output capabilities, style resolution, span and cell rendering, command-menu and highlight markup, and picture-row column serialization.
Link policies and concealed styling MarkupString/UrlPolicy.cs, MarkupString/MarkupRegistry.cs, MarkupString.Html/*, MarkupString.Ansi/Emitters/*, MarkupString.Ansi/AnsiStyle.cs, MarkupString.Ansi/SgrWriter.cs	Adds configurable link checks for decoding and output, HTML tag validation, and concealed ANSI style handling.
ANSI and VT decoding MarkupString.Ansi/Decoding/AnsiDisplay.cs, MarkupString.Ansi/Decoding/VtPlugins.cs, MarkupString.Tests/Decoding/VtDecodingTests.cs	Adds ANSI style resolution, VT controls, SGR styles and colors, OSC handling, terminal replies, and profile capability conversions.
Picture decoding and storage MarkupString.Ansi/Decoding/PictureStore.cs, MarkupString.Ansi/Decoding/PicturesPlugin.cs, MarkupString.Ansi/Decoding/PngDecoder.cs, MarkupString.Ansi/Decoding/SixelDecoder.cs, MarkupString.Tests/Decoding/PictureDecodingTests.cs	Adds picture storage and caching, PNG and sixel decoding, Kitty and iTerm2 picture handling, and placement and overlay support.
MXP and Pueblo decoding MarkupString.Mxp/Decoding/*, MarkupString.Pueblo/Decoding/*, MarkupString.Tests/Decoding/MxpDecodingTests.cs, MarkupString.Tests/Decoding/PuebloDecodingTests.cs	Adds MXP and Pueblo protocol plugins that convert supported terminal text and markup into decoded lines, interactions, events, and other markup.
Dependency-injection package and integration MarkupString.Extensions.DependencyInjection/*, MarkupString.Tests/Decoding/InjectionTests.cs, MarkupString.AotSmoke/*, MarkupString.slnx, .github/workflows/ci.yml	Adds configuration options, service registration, decoder creation, integration tests, AOT smoke coverage, and project and package wiring.

Estimated code review effort: 5 (Critical) | ~120 minutes

Sequence Diagram(s)

sequenceDiagram
  participant Caller
  participant Decoder
  participant VtTokenizer
  participant SgrPlugin
  participant DecodeContext
  participant DisplayRegistry
  participant SpanRenderer
  Caller->>Decoder: Feed terminal text
  Decoder->>VtTokenizer: Tokenize input
  VtTokenizer->>Decoder: Send parsed tokens
  Decoder->>SgrPlugin: Dispatch matching sequence
  SgrPlugin->>DecodeContext: Update style markup
  Decoder-->>Caller: Return completed lines
  Caller->>DisplayRegistry: Resolve line markup
  Caller->>SpanRenderer: Render styled spans

Loading

Possibly related PRs

• SharpMUSH/MarkupString#71: Adds StandInMarkup handling to AsciiFold.Fold(MarkupText); this pull request adds ASCII display renderers that fold individual strings.

Suggested reviewers: claude

Merge Risk: High · up to 5a6d0

This change decodes untrusted server output. As written, a malicious or buggy server can crash a client process through MXP recursion, and can bypass link scheme checks or inject terminal escapes. It can also make a client allocate very large amounts of memory through pictures. These should be fixed before merge, along with the smaller decoding defects.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts