Repository navigation
Take TelnetNegotiationCore 4.11.0 for its ECHO fixes - #130
Merged
Merged
Conversation
4.11.0 answers a server's WONT ECHO with DONT ECHO when it was echoing and stops answering a repeated WILL ECHO (RFC 1143), which matters at a password prompt now that local echo follows the server's ECHO state (#128). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Rqqt7WwMmhxVJpERSzReCy
|
Caution Review failedThe pull request is closed.
|
HarryCordewener
marked this pull request as ready for review
November 11, 2026 01:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps TelnetNegotiationCore 4.9.0 → 4.11.0, which carries HarryCordewener/TelnetNegotiationCore#186:
WONT ECHOwithDONT ECHOwhen the server was echoing (it sent nothing before).WILL ECHOwhile the server is already echoing is no longer answered withDO ECHO(RFC 854/1143), so two implementations cannot loop on it.This matters at a password prompt, where local echo now follows the server's ECHO state (#128). No source change was needed;
TelnetSession'sOnEchoStateChangedhook is unchanged.Checks:
dotnet build -c Release SharpMUTerm.slnxclean, 0 warnings. All seven suites green except Core'sAReadOnlyCacheDirectory_DegradesToMemoryOnly, which fails only because this container runs as root (unrelated, fails on main here too).CHANGELOG updated under Unreleased → Fixed.
Generated by Claude Code