[2026-07] Clarify NumberField and MoneyField event documentation - #4703
Open
johnnie-chen wants to merge 1 commit into
Open
johnnie-chen wants to merge 1 commit into
johnnie-chen wants to merge 1 commit into
Conversation
This was referenced Sep 18, 2026
johnnie-chen
marked this pull request as ready for review
September 18, 2026 18:38
2 tasks
johnnie-chen
added
the
needs-rc-port
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
NumberField and MoneyField event descriptions do not explain that stepping a value fires both
inputandchange. This clarifies the existing behavior for Checkout and Customer Accounts in API version 2026-07.Source documentation change: https://meteorite.shopify.io/repos/shop/world/pulls/2079504
Solution
Clarify that
changefires when the value is committed on blur or Enter and that both events fire on each arrow-key step. NumberField also documents its increment/decrement controls.Update the two declaration comments and their generated documentation for both surfaces. This changes documentation only. Generated output is limited to the relevant event descriptions; unrelated generator drift is excluded.
🎩
yarn buildandyarn type-checkpassed.yarn lintpassed with two Git-ignored build outputs temporarily moved aside and restored afterward. The existing ESLint ignore patterns misscheckout/preact.jsandcustomer-account/preact.jsafter a build.git diff --checkpassed.Checklist
Related release PRs