[2025-10] Clarify NumberField and MoneyField event documentation - #4707
Merged
johnnie-chen merged 1 commit intoSep 22, 2026
Conversation
oliverigor
approved these changes
Sep 22, 2026
johnnie-chen
deleted the
johnnie/clarify-number-money-field-events-2025-10
branch
September 23, 2026 18:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
NumberField and MoneyField event descriptions omit that stepping a value fires both
inputandchange. This documents the existing shared Checkout/Customer Accounts behavior for API version 2025-10.Backport of #4703. Source documentation change: https://meteorite.shopify.io/repos/shop/world/pulls/2079504
Solution
Clarify blur/Enter commitment and per-step
inputandchangeevents. NumberField covers increment/decrement controls and arrow keys; MoneyField covers arrow keys. Update the two declaration comments and generated reference data for both surfaces. There are no runtime changes or changes to the distinct event names, optionality, or callback types.The two event interfaces on this branch contain committed merge-conflict fragments in their JSDoc. Clean up those fragments while adding the clarification, preserving the existing callback types and MDN links. The corrupted blocks also contain duplicate
blurandchangedeclarations; retain one declaration of each with the same optional callback types. This cleanup is limited to NumberField and MoneyField; it does not change the six other affected field interfaces.Regenerate both surfaces and retain only the two affected event-interface entries. This includes cleaning the corrupted blur descriptions as well as clarifying change/input descriptions; unrelated generator drift is excluded.
🎩
yarn docs:checkout 2025-10andyarn docs:customer-account 2025-10completed.yarn lint,yarn build,yarn type-check, andgit diff --checkpassed. Lint ran before build to avoid the existing generated-entrypoint ignore-pattern issue.Checklist