Skip to content

Let empty Kith users open the app without fake data #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sarthakagrawal927 merged 1 commit into from
Aug 23, 2026
Merged

Let empty Kith users open the app without fake data #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ios/Kith.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -565,7 +565,7 @@
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
CODE_SIGN_STYLE = Automatic;
COPY_PHASE_STRIP = NO;
CURRENT_PROJECT_VERSION = 6;
CURRENT_PROJECT_VERSION = 7;
DEBUG_INFORMATION_FORMAT = dwarf;
DEVELOPMENT_TEAM = 8F7LXHTJZR;
ENABLE_STRICT_OBJC_MSGSEND = YES;
Expand Down Expand Up @@ -762,7 +762,7 @@
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
CODE_SIGN_STYLE = Automatic;
COPY_PHASE_STRIP = NO;
CURRENT_PROJECT_VERSION = 6;
CURRENT_PROJECT_VERSION = 7;
DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
DEVELOPMENT_TEAM = 8F7LXHTJZR;
ENABLE_NS_ASSERTIONS = NO;
Expand Down
4 changes: 4 additions & 0 deletions ios/Sources/Kith/KithOnboardingView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,10 @@ struct KithOnboardingView: View {
.disabled(name.trimmingCharacters(in: .whitespacesAndNewlines).isEmpty)
.opacity(name.trimmingCharacters(in: .whitespacesAndNewlines).isEmpty ? 0.5 : 1)

Button("Open Kith first") { model.finishOnboarding() }
.font(.headline)
.frame(maxWidth: .infinity, minHeight: 44)

Text("No Contacts permission. This is saved on your iPhone first and works offline.")
.font(.footnote)
.foregroundStyle(KithPalette.espresso.opacity(0.58))
Expand Down
12 changes: 12 additions & 0 deletions ios/Tests/KithUITests/KithUITests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,18 @@ final class KithUITests: XCTestCase {
XCTAssertTrue(app.staticTexts["Coffee after the market."].waitForExistence(timeout: 4))
}

func testOnboardingCanOpenKithWithoutCreatingAPerson() {
let app = launch(["--onboarding-demo"])

let openKith = app.buttons["Open Kith first"]
XCTAssertTrue(openKith.waitForExistence(timeout: 4))
openKith.tap()

XCTAssertTrue(app.staticTexts["Who do you want to keep close?"].waitForExistence(timeout: 4))
XCTAssertTrue(app.buttons["Add someone"].exists)
XCTAssertFalse(app.buttons.matching(NSPredicate(format: "label CONTAINS[c] %@", "Leela")).firstMatch.exists)
}

func testOnboardingResumesAtContextForItsSavedPerson() {
let app = launch(["--onboarding-resume-demo"])

Expand Down
2 changes: 1 addition & 1 deletion ios/project.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ settings:
DEVELOPMENT_TEAM: 8F7LXHTJZR
CODE_SIGN_STYLE: Automatic
TARGETED_DEVICE_FAMILY: "1"
CURRENT_PROJECT_VERSION: 6
CURRENT_PROJECT_VERSION: 7
MARKETING_VERSION: 1.0.0
ENABLE_USER_SCRIPT_SANDBOXING: YES
packages:
Expand Down
6 changes: 5 additions & 1 deletion ios/scripts/check.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,11 @@ devices = json.load(sys.stdin).get("devices", {})
candidates = []
for runtime, entries in devices.items():
for device in entries:
if device.get("isAvailable") and device.get("name") == "iPhone 17 Pro":
if (
device.get("isAvailable")
and device.get("deviceTypeIdentifier")
== "com.apple.CoreSimulator.SimDeviceType.iPhone-17-Pro"
):
candidates.append((runtime != "com.apple.CoreSimulator.SimRuntime.iOS-26-2", runtime, device["udid"]))
if candidates:
print(sorted(candidates)[0][2])
Expand Down
Loading