Skip to content

fix: point recommended pipeline at scripts/pool_vera_scores.py - #251

Open
luca-belli wants to merge 1 commit into
mainfrom
fix/recommended-pipeline-pool-path
Open

luca-belli wants to merge 1 commit into
mainfrom
fix/recommended-pipeline-pool-path

Conversation

@luca-belli

Copy link
Copy Markdown
Collaborator

Summary

legacy/run_recommended_vera_pipeline.sh sets SCRIPT_DIR to its own folder and called "$SCRIPT_DIR/pool_vera_scores.py". Since #243 moved the shell script into legacy/, that path is legacy/pool_vera_scores.py, which doesn't exist; the pool script lives in scripts/. The recommended pipeline therefore failed at the end of each suite (extracting the evaluation folder from the log) and at its final pooling step.

  • Both calls now use scripts/pool_vera_scores.py. The script already cds to the repo root first (line 53).
  • Three comments updated to name the right path.
  • CHANGELOG [Unreleased] → Fixed.

legacy/run_pipeline.py is invoked correctly (python -m legacy.run_pipeline), so pooling was the only broken step.

Test plan

  • bash -n legacy/run_recommended_vera_pipeline.sh
  • uv run python scripts/pool_vera_scores.py --help from the repo root. The script adds the repo root to sys.path itself.
  • --extract-from-log on a dummy log fails cleanly ("Could not find any 'Evaluations saved to:' line"), not with an import error
  • Full recommended pipeline not run (calls live models)

🤖 Generated with Claude Code

The shell script moved to legacy/ but still looked for the pool script
beside itself, so its final pooling step failed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@luca-belli
luca-belli requested a review from a team as a code owner October 9, 2026 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant