Repository navigation
Add Magic character and held-item value administration - #70
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Magic has resonance administration but no equivalent controls for equilibrium, casting mode or several held-item values. Add character inspection/reset, equilibrium get/set/add/remove/reset, casting-mode get/set/reset, explicit resonance removal, artifact fill/muffle/wear operations and weapon Rift/durability operations. Preserve existing commands and permissions.
Character edits validate the current loaded character, clamp values, clear affected passive drift, save immediately and refresh spell modifiers. Failed saves roll back the edit. Held-item edits preserve identity and sockets, refresh affected lore and keep the final durability point. Staff command documentation and a Dev-only integration script are included. Focus controls are implemented separately in TF-Minecraft/RPCharacters#137.
Validation:
mvn -B --no-transfer-progress clean verify: 730 tests passing; 100% line, branch and instruction coverage.Published https://github.com/TF-Minecraft/Magic/releases/tag/v0.13.0 from merged main commit
890348121320cf1f36280f017119bca337828da0. The release workflow passed and its JAR, embedded version, checksum and build provenance were verified. All 14 integration groups passed again using the exact release jars on Dev. Dev now actively runsmagic-0.13.0.jar(SHA-256c486960651d784e7574d86f696f7d4b54bd183307687f727206f701d2dbd31f4). The dedicated integration character was reset, cleared and deopped.Final release review: clean with no further code fixes. Fresh local tests (55), the full Linux suite (730 with all coverage gates), and the exact-release Dev tests passed. PR marked ready and squash-merged. Main and Tutorial now have the same verified release and the two updated Magic help lines staged as a routine PUSH for their next normal restart; both stayed running. Prior jars/help files are backed up in each user-accessible backup tree under
admin-values-release-6998629d. Final verification found no unrelated plugin/config changes. No Gameplay Guide page or section change is needed: these are staff-only tools and player mechanics/recipes are unchanged.