Skip to content

Add Magic character and held-item value administration - #70

Merged
XxFran10xX merged 2 commits into
mainfrom
feat/magic-admin-values
Oct 23, 2026
Merged

XxFran10xX merged 2 commits into
mainfrom
feat/magic-admin-values

Conversation

@XxFran10xX

@XxFran10xX XxFran10xX commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Magic has resonance administration but no equivalent controls for equilibrium, casting mode or several held-item values. Add character inspection/reset, equilibrium get/set/add/remove/reset, casting-mode get/set/reset, explicit resonance removal, artifact fill/muffle/wear operations and weapon Rift/durability operations. Preserve existing commands and permissions.

Character edits validate the current loaded character, clamp values, clear affected passive drift, save immediately and refresh spell modifiers. Failed saves roll back the edit. Held-item edits preserve identity and sockets, refresh affected lore and keep the final durability point. Staff command documentation and a Dev-only integration script are included. Focus controls are implemented separately in TF-Minecraft/RPCharacters#137.

Validation:

  • Two implementation self-review rounds completed, followed by a post-Dev review of smoke-test response matching (three rounds total). Local behavior tests rerun after fixes: 55 passing; local Node syntax check passing.
  • Linux mvn -B --no-transfer-progress clean verify: 730 tests passing; 100% line, branch and instruction coverage.
  • Windows full-suite failures are existing Linux filesystem assumptions (directory sync and filename case); full verification uses the Linux build environment.
  • TFMCDev01: all 14 integration groups passed, covering permission denial, inspection, arithmetic/bounds, invalid input, defaults, Focus preservation, console targets, artifact fill/muffle/wear, weapon Rift/durability and persistence through logout/rejoin. No command exceptions. Existing startup warnings match the previous startup log.

Published https://github.com/TF-Minecraft/Magic/releases/tag/v0.13.0 from merged main commit 890348121320cf1f36280f017119bca337828da0. The release workflow passed and its JAR, embedded version, checksum and build provenance were verified. All 14 integration groups passed again using the exact release jars on Dev. Dev now actively runs magic-0.13.0.jar (SHA-256 c486960651d784e7574d86f696f7d4b54bd183307687f727206f701d2dbd31f4). The dedicated integration character was reset, cleared and deopped.

Final release review: clean with no further code fixes. Fresh local tests (55), the full Linux suite (730 with all coverage gates), and the exact-release Dev tests passed. PR marked ready and squash-merged. Main and Tutorial now have the same verified release and the two updated Magic help lines staged as a routine PUSH for their next normal restart; both stayed running. Prior jars/help files are backed up in each user-accessible backup tree under admin-values-release-6998629d. Final verification found no unrelated plugin/config changes. No Gameplay Guide page or section change is needed: these are staff-only tools and player mechanics/recipes are unchanged.

@coderabbitai

coderabbitai Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 3dd99f0f-200a-428c-adeb-c0fe54050932
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the size:XL 500-999 effective changed lines (tests excluded in mixed PRs). label Oct 23, 2026
@XxFran10xX
XxFran10xX marked this pull request as ready for review October 23, 2026 18:54
@XxFran10xX
XxFran10xX merged commit 8903481 into main Oct 23, 2026
4 checks passed
@XxFran10xX
XxFran10xX deleted the feat/magic-admin-values branch October 23, 2026 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL 500-999 effective changed lines (tests excluded in mixed PRs).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant