Repository navigation
Add checked Focus get, set, add, remove and reset commands - #137
Merged
Merged
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
XxFran10xX
marked this pull request as ready for review
October 23, 2026 18:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Focus administration currently supports only full restoration. Add
/focus get,set,add,removeandresetusing the existingrpchar.focus.adminpermission and loaded-character checks. Edits clamp without integer overflow, save immediately and report the resulting balance. Failed writes roll back the balance; existing restore now uses the same checked edit path.Add permission, syntax, failure, clamping and persistence tests, tab completion and a staff command reference. TF-Minecraft/Magic#70 provides the related Magic player/item controls and Dev integration script; these changes remain independently compatible.
Validation:
mvn -B --no-transfer-progress clean verify: 2,601 tests passing and the repository coverage gate passing.Published https://github.com/TF-Minecraft/RPCharacters/releases/tag/v2.31.0 from merged main commit
f37f7052bb2e5f32c5001454967e0dd90fa13734. The release workflow passed and its JAR, embedded version, checksum and build provenance were verified. All 14 companion integration groups passed again using the exact release jars on Dev. Dev now actively runsrpcharacters-2.31.0.jar(SHA-256c3686cd7d74cb725984dfefe23d0f1c37a8431ebcf57b33533d173a4e1c33b12). No RPCharacters live config or state files were edited directly. The dedicated integration character was restored, cleared and deopped.Final release review: clean with no further code fixes. Fresh local tests (35), the full Linux suite (2,601 with its coverage gate), and the exact-release Dev tests passed. PR marked ready and squash-merged. Main and Tutorial now have the same verified release staged as a routine PUSH for their next normal restart; both stayed running. Prior jars are backed up in each user-accessible backup tree under
admin-values-release-6998629d. Final verification found no unrelated plugin/config changes. No Gameplay Guide page or section change is needed: these are staff-only tools and ordinary player Focus mechanics are unchanged.