Skip to content

Add checked Focus get, set, add, remove and reset commands - #137

Merged
XxFran10xX merged 1 commit into
mainfrom
feat/focus-admin-values
Oct 23, 2026
Merged

XxFran10xX merged 1 commit into
mainfrom
feat/focus-admin-values

Conversation

@XxFran10xX

@XxFran10xX XxFran10xX commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Focus administration currently supports only full restoration. Add /focus get, set, add, remove and reset using the existing rpchar.focus.admin permission and loaded-character checks. Edits clamp without integer overflow, save immediately and report the resulting balance. Failed writes roll back the balance; existing restore now uses the same checked edit path.

Add permission, syntax, failure, clamping and persistence tests, tab completion and a staff command reference. TF-Minecraft/Magic#70 provides the related Magic player/item controls and Dev integration script; these changes remain independently compatible.

Validation:

  • Two self-review rounds completed, with local Focus tests rerun after fixes (35 tests passing).
  • Linux mvn -B --no-transfer-progress clean verify: 2,601 tests passing and the repository coverage gate passing.
  • Windows full-suite failures are existing filesystem assumptions; full verification uses the Linux build environment.
  • TFMCDev01: all 14 integration groups passed with the companion Magic PR, including Focus permission denial, get/set/add/remove/reset, integer bounds, actual persisted balances, preservation through Magic reset and logout/rejoin. No command exceptions. Existing startup warnings match the previous startup log.

Published https://github.com/TF-Minecraft/RPCharacters/releases/tag/v2.31.0 from merged main commit f37f7052bb2e5f32c5001454967e0dd90fa13734. The release workflow passed and its JAR, embedded version, checksum and build provenance were verified. All 14 companion integration groups passed again using the exact release jars on Dev. Dev now actively runs rpcharacters-2.31.0.jar (SHA-256 c3686cd7d74cb725984dfefe23d0f1c37a8431ebcf57b33533d173a4e1c33b12). No RPCharacters live config or state files were edited directly. The dedicated integration character was restored, cleared and deopped.

Final release review: clean with no further code fixes. Fresh local tests (35), the full Linux suite (2,601 with its coverage gate), and the exact-release Dev tests passed. PR marked ready and squash-merged. Main and Tutorial now have the same verified release staged as a routine PUSH for their next normal restart; both stayed running. Prior jars are backed up in each user-accessible backup tree under admin-values-release-6998629d. Final verification found no unrelated plugin/config changes. No Gameplay Guide page or section change is needed: these are staff-only tools and ordinary player Focus mechanics are unchanged.

@coderabbitai

coderabbitai Bot commented Oct 23, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the size:M 30-99 effective changed lines (tests excluded in mixed PRs). label Oct 23, 2026
@XxFran10xX
XxFran10xX marked this pull request as ready for review October 23, 2026 18:54
@XxFran10xX
XxFran10xX merged commit f37f705 into main Oct 23, 2026
4 checks passed
@XxFran10xX
XxFran10xX deleted the feat/focus-admin-values branch October 23, 2026 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 effective changed lines (tests excluded in mixed PRs).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant