fix: log HybridFile stream close errors with LOG.error - #4727
Merged
EmmanuelMess merged 1 commit intoSep 23, 2026
Merged
Conversation
Replace e.printStackTrace() when closing SFTP read-ahead streams. Matches existing SLF4J usage in HybridFile. Fixes TeamAmaze#2755
EmmanuelMess
added
the
PR-Code-Review-Passed
TranceLove
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
HybridFile, closing the SFTP read-ahead stream usede.printStackTrace(). Use existingLOG.error(..., e)instead.Base branch: release/4.0 (per @EmmanuelMess on #4726).
Note: other
printStackTracehits inCloudStreamServerare inside comments only;ErrorActivityusesprintStackTrace(PrintWriter)for crash report text and is intentional.Fixes #2755