Skip to content

fix: log HybridFile stream close errors with LOG.error #4727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EmmanuelMess merged 1 commit into from
Sep 23, 2026
Merged

fix: log HybridFile stream close errors with LOG.error #4727

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/src/main/java/com/amaze/filemanager/filesystem/HybridFile.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -609,7 +609,7 @@
*
* @deprecated use {@link #isDirectory(Context)} to handle content resolvers
*/
public boolean isDirectory() {

Check warning on line 612 in app/src/main/java/com/amaze/filemanager/filesystem/HybridFile.java

View workflow job for this annotation

GitHub Actions / Build debug and run Jacoco tests 

[dep-ann] deprecated item is not annotated with @deprecated

Check warning on line 612 in app/src/main/java/com/amaze/filemanager/filesystem/HybridFile.java

View workflow job for this annotation

GitHub Actions / Build debug and run Jacoco tests 

[dep-ann] deprecated item is not annotated with @deprecated
boolean isDirectory;
switch (mode) {
case SFTP:
Expand Down Expand Up @@ -703,7 +703,7 @@
/**
* @deprecated use {@link #folderSize(Context)}
*/
public long folderSize() {

Check warning on line 706 in app/src/main/java/com/amaze/filemanager/filesystem/HybridFile.java

View workflow job for this annotation

GitHub Actions / Build debug and run Jacoco tests 

[dep-ann] deprecated item is not annotated with @deprecated

Check warning on line 706 in app/src/main/java/com/amaze/filemanager/filesystem/HybridFile.java

View workflow job for this annotation

GitHub Actions / Build debug and run Jacoco tests 

[dep-ann] deprecated item is not annotated with @deprecated
long size = 0L;

switch (mode) {
Expand Down Expand Up @@ -1062,7 +1062,7 @@
*
* @deprecated use forEachChildrenFile()
*/
public ArrayList<HybridFileParcelable> listFiles(Context context, boolean isRoot) {

Check warning on line 1065 in app/src/main/java/com/amaze/filemanager/filesystem/HybridFile.java

View workflow job for this annotation

GitHub Actions / Build debug and run Jacoco tests 

[dep-ann] deprecated item is not annotated with @deprecated

Check warning on line 1065 in app/src/main/java/com/amaze/filemanager/filesystem/HybridFile.java

View workflow job for this annotation

GitHub Actions / Build debug and run Jacoco tests 

[dep-ann] deprecated item is not annotated with @deprecated
ArrayList<HybridFileParcelable> arrayList = new ArrayList<>();
forEachChildrenFile(context, isRoot, arrayList::add);
return arrayList;
Expand Down Expand Up @@ -1117,7 +1117,7 @@
LOG.debug("Closing input stream for {}", getPath());
super.close();
} catch (Throwable e) {
e.printStackTrace();
LOG.error("Error closing input stream for {}", getPath(), e);
} finally {
LOG.debug("Closing client for {}", getPath());
rf.close();
Expand Down
Loading