Repository navigation
Add shared Tauri Android and iOS client build paths - #21
Merged
Merged
Conversation
Reuse the desktop host with isolated mobile navigation, safe launcher return, Android APK/AAB and iOS simulator/device build paths, signed release gates, and truthful engineering artifact documentation.
Use the locked npm lifecycle when Xcode and Gradle re-enter Tauri, avoid removed legacy Android SDK tools, and reject credential/query-bearing server addresses before any local preference is saved.
Use the SDK's actual versioned package path and supported command-line tools, collect the real iOS simulator architecture output, and add a parameter-free app return signal without importing credentials or server URLs. Exercise the Android launcher, remote navigation and native permission boundary.
…rowser sign-in return
… [skip ci] Keep shared library entry points and current custom-protocol configuration; preserve responsive Web and signed-release boundaries. Record portable 9 Python,4 JavaScript and7 Rust policy checks while retaining the Android ANR gate.
LIghtJUNction
added a commit
that referenced
this pull request
Nov 20, 2026
…p ci] Preserve current passkeys, session identities, source/referral inputs and migration behavior while integrating the native app-login grant flow. Verified exact tree 2ba69fb: 112 Rust tests passed (one existing large-scale case ignored), actual server build, and all 8 real-server browser groups passed with Playwright 1.62.1. Original environment failures and the untouched-main migration assertion control are retained. Current Android/mobile integration remains in draft PR #21; no native release, production deployment or real OAuth session is qualified by this merge.
…kip ci] Bring merged server PR #24 into the mobile branch. Its 13 files do not overlap the 22-file mobile change; the complete resulting Git tree is checked against the exact source blobs from both parents. Desktop/mobile build inputs and the original Android return gate remain unchanged. Server validation: 112 Rust tests and 8 real-browser groups passed on tree 2ba69fb. Current native Android acceptance is still in progress; this commit does not claim a platform pass or authorize distribution.
LIghtJUNction
force-pushed
the
feat/mobile-client-packaging
branch
from
November 20, 2026 17:14
06b2863 to
92df7e2
Compare
A real API 35 emulator launched the APK successfully but uiautomator returned before its XML existed. Poll fresh layouts within the original 45-second deadline, record probe output, and reject transport errors and stale XML. Preserve every application assertion and keep the APK unchanged. All 14 mobile packaging and probe regression tests pass.
The current API35 smoke reproduced a focus ANR on warm login return, followed by wry's GetUrl reply panicking after its receiver timed out. The return callback synchronously requested the current WebView URL from the same platform loop. Dispatch the existing selected-origin and login-page checks to the blocking worker pool before sending the unchanged payload-free event. Keep the incoming URL whitelist and cold-start navigation rules intact. Rust formatting and whitespace checks passed. Android rebuild, unchanged 45-second return checks, and the real native/server/browser integration remain pending; keep PR21 in draft. Reproduction and diagnosis: evidence-hf21/android-root-smoke.json and android-deep-link-anr-diagnosis.json.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Make the existing Tauri client available as Android and iOS engineering builds, using one mobile WebView and a responsive local connection screen. The current Android candidate now passes both the unchanged device regression and the actual native WebView → system Chrome → private server consent/return flow.
Changes and resulting behavior
Fixed candidate and merge tree
5d9313df5dc9c295a2ab575107ed665b3a92dc19b6e3e5439705b6c94e04180734c8bfeb49c33e53dd3c20e40093892cf14f50fe09cd8c6c93350525b6e3e5439705b6c94e04180734c8bfeb49c33e53935fc98fa8aa62ef84b6d12205f9216c6e8eaf2c9ffd3389bbe54a95a83c9b23Main is an ancestor of this head. Native
git merge-treeproduced the exact validated tree with no difference from the tested checkout.Completed Android acceptance — 2026-11-20
The engineering APK is
best.lmm.hireferry.debug, x86_64, 42,747,530 bytes. Rust 1.100.0, JDK 21, SDK 37.0/build-tools 37.0.0 and the exact prepared NDK 29.0.13846066 were used. The cached build completed in 52.525 seconds. Restoring the original task-owned debug certificate required signing only; all 934 non-signature ZIP payloads were verified identical, and package/ABI/signature verification passed. No maintainer release key was used.hireferry://login-returnschemeThe joint-only continuation completed in 113.911 seconds, including a 38.032-second API35 boot. It used Chrome 124.0.6367.219 and the real #24 server binary with verified identical server inputs. The passed baseline was reused by its exact receipt hash and was not rerun. All execution used the private
emulator-5582fixture, bounded resources, and the shared owner lock.Preserved failures and the fixture correction
The prior application checkpoint
42d536dreproduced a 5,006 ms focus-event ANR, followed bySIGABRT. The captured Wry 0.57.0 panic identifies the queued URL reply sending to a receiver that had timed out. The final callback change directly addresses that event-loop wait, and the original device assertions now pass.The first fixed-APK run passed the full baseline but stopped before joint login because the private Chrome launcher incorrectly supplied
--disable-sync. Chrome read the flags and then produced a null-pointerSIGSEGV. The installed Playwright Android defaults explicitly omit that flag. The continuation removes this single launch flag, adds diagnostics, and leaves the actual application-flow assertions byte-identical. Chrome then exposed the requested debug socket and completed the real joint flow. The original crash, failed attempt and exact script hashes remain preserved; the native stack was not symbolized as an IdentityManager stack.Earlier SDK-path, cache/signature-preflight, UI-dump readiness and boot-timeout attempts also remain separate evidence. None is recast as a successful application test.
Portable and iOS evidence
The recorded portable checkpoints passed 14 Python mobile tests, 4 JavaScript tests, and 7 Rust tests importing the actual navigation policy; formatting, syntax, locked metadata and documentation-link checks also passed. The final handler was subsequently compiled into and exercised through the Android APK above.
The historical iOS simulator job from run 39885106014 passed at its original merge source. This work does not claim a new current-source iOS device or simulator run.
Evidence locations and hashes
Durable development-machine evidence is under:
/home/lightjunction/Documents/GITHUB/pr-cleanup-org-20261120/evidence-hf21/android-fixed-smoke-1795205175/smoke/android-smoke.json6991b9a95c394eb6fb0740ff3fa0c3dfd9598089bb17c092521aa189ad3dd599android-fixed-joint.jsonfaab8e9375bb15611914120786a360f0e201d4f2e7a6117e0f241dd89c2637a8android-fixed-joint-1795206290/joint/native-app-login.jsond5ded8a35f0b92fe9e3a90ca0e188da32d0c7bb914ed850d28f196e2cbc41f5bandroid-chrome-preparation-diagnosis.json7d81283e6e33c58fab36df71dfa255236ec03cd24cc5d69b6b2ead6da7a6a6e2Build/signing provenance is in
android-fixed-build-final.json; the application ANR diagnosis is inandroid-deep-link-anr-diagnosis.json. APKs, screenshots, userdata and logs remain outside Git.Distribution boundary
This PR enables engineering builds. Formal server/CLI/desktop publication remains tag/manual controlled, and mobile signing remains an explicit
workflow_dispatchoperation using themobile-signingenvironment. No release/tag, workflow dispatch, store submission, production-account login or physical-device acceptance was performed.