Repository navigation
Add one-time browser consent and safe native login return - #24
Merged
Merged
Conversation
… [skip ci] Preserve source/referral metadata, passkeys, session IDs and current schema migrations. Bind new Google app-request metadata to the existing query fields and update stale fixture final-version assertions to schema20 without changing rollback or data checks.112 targeted Rust checks and real server build passed.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
LIghtJUNction
added a commit
that referenced
this pull request
Nov 20, 2026
…kip ci] Bring merged server PR #24 into the mobile branch. Its 13 files do not overlap the 22-file mobile change; the complete resulting Git tree is checked against the exact source blobs from both parents. Desktop/mobile build inputs and the original Android return gate remain unchanged. Server validation: 112 Rust tests and 8 real-browser groups passed on tree 2ba69fb. Current native Android acceptance is still in progress; this commit does not claim a platform pass or authorize distribution.
LIghtJUNction
added a commit
that referenced
this pull request
Nov 20, 2026
…kip ci] Bring merged server PR #24 into the mobile branch. Its 13 files do not overlap the 22-file mobile change; the complete resulting Git tree is checked against the exact source blobs from both parents. Desktop/mobile build inputs and the original Android return gate remain unchanged. Server validation: 112 Rust tests and 8 real-browser groups passed on tree 2ba69fb. Current native Android acceptance is still in progress; this commit does not claim a platform pass or authorize distribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Complete the server side of native browser-to-WebView sign-in. The public request ID is not a credential: the originating WebView retains a private HttpOnly verifier cookie, the separate browser grants explicit consent, and the server atomically issues one ordinary-member session.
The current server-side Rust and real-browser acceptance is complete. Native-client engineering acceptance remains tracked in mobile PR #21 before mobile distribution is qualified.
Current integration — 2026-11-20
Resolved against main
397addaaeb9568063f7f3806d3835ae035aff871:app_requestto a live server request, preserving the existingsourceandrefinputs. A regression now checks all three values together.Original head:
cf650c46794215cc2a861ec4ce91f6a5346bf3bd.Updated head:
9e44760257f820f30620584463fefb83bc48afd8.Validated tree:
2ba69fbcacf05d85f0b55f5d83a662f752730b65.GitHub's tree and both integration parents were read back and match the isolated development-machine result.
Current Rust acceptance
Installed Rust 1.100.0, one build job, independent target directory, original dependency lock retained:
cargo fmt --all -- --check cargo metadata --locked --no-deps --format-version 1 cargo test --locked --no-fail-fast --lib --test auth_flows --test cli_auth --test app_login --test relations cargo build --locked --bin hireferry git diff --checkFormatting, locked metadata and the actual server binary build passed. These targeted suites do not claim the entire workspace/platform matrix.
Historical fixture version assertions corrected
The first run exposed main's notification migration test expecting schema 19 while current
db::migratereaches 20. The exact untouched main reproduced that same failure in an independent control worktree. The passkey and CLI migration tests contained the same outdated final-version expectation; this PR's old additive-login test still expected 13.The fix updates those current-final-version assertions to 20. It leaves the actual migration implementation unchanged and preserves data-count checks, the failed migration's original version 14/7, atomic rollback, absence of partial tables, repeated migration, and credential behavior. The complete targeted suites above then passed. The original failures and control log remain in the evidence directory.
Current browser acceptance
All eight browser groups passed against the actual current Rust server and a disposable SQLite database, with pinned Playwright 1.62.1, system Chromium and independent browser cookie contexts:
node tests/app-login.browser.mjsand the finalgit diff --checkboth exited 0. The validated tree remains2ba69fbcacf05d85f0b55f5d83a662f752730b65; no source changes were needed after the 112-test Rust/server build checkpoint.The first npm attempt timed out before browser execution. The configured registry then installed the same pinned package. A first Chromium launch failed before business tests because the disk-backed TMPDIR exceeded its Unix socket path limit; the successful run used a shorter, private disk directory. All original assertions and timeouts were retained, and both failed environment attempts are preserved.
Evidence:
/home/lightjunction/Documents/GITHUB/pr-cleanup-org-20261120/evidence-hf24/browser-result.json,browser-short-checks.json,browser-short-0.log, and the retained Rust/control logs. The completed files were also read through the Project Z client after the shared maintenance client's result channel timed out.Native-client acceptance remains separate
Mobile PR #21 remains draft while its current Android return-to-launcher behavior and combined native WebView/server sign-in flow are verified. The prior Android stdout proves a timeout after a warm login-return; it contains no retrievable ANR stack. Current source investigation is continuing on an owned emulator. This server-side acceptance does not qualify an Android/iOS release or relabel historical iOS evidence as a current-head result.
Scope
All automated account and financial inputs are synthetic. Browser fixtures disable Google, SMTP and webhooks and block external page requests. Real Google OAuth, real phones, production schema changes, production sessions, signing, store publication and deployment have not been used or claimed. The manual workflow was not dispatched.