Repository navigation
Localize CLI presentation while preserving native adapter contracts - #1
Merged
Merged
Conversation
Resolve lib/main conflicts while preserving current Pi and CC Switch commands, argument validation, grants, receipts and credential isolation. Keep machine JSON canonical and localize presentation. Extend catalog and scope regression coverage. Draft checkpoint: catalog validation passes with 261 keys; complete Rust validation follows in isolated development checkout.
Keep fallback text lifetimes local and convert the complete native application result at the CLI boundary. Format the conflict resolution with the pinned toolchain. Local mise Rust 1.100.0: 127 tests pass, 2 existing opt-in isolated Secret Service checks ignored; full-target/all-feature Clippy -D warnings, rustfmt and 261-key catalog check pass.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
LIghtJUNction
added a commit
that referenced
this pull request
Nov 20, 2026
Preserve #1's current native adapters and canonical JSON behavior. Retain this branch's documentation, checker fixture tests, untrusted-path regression, and UTF-8 callback response language/length validation. Move detailed current Chinese scope into a usage guide and mirror current features in English. Local mise Rust 1.100.0: 129 tests passed, 2 existing isolated Secret Service checks ignored; 11 Python validator tests, fmt, all-target/all-feature Clippy -D warnings, catalog and source-package file checks passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The original i18n branch conflicted with the current native Pi and CC Switch implementation. Applying its old main.rs would remove commands and permission/transaction boundaries added since the branch was opened.
What changed
Validation
Isolated development checkout, pinned mise Rust 1.100.0, Cargo jobs=1:
Validated/published tree: 106f8a0016df303fee9a1f7eaf28bfd9b1b401c9. No live credential-store acceptance, real account authorization, application configuration, production change or release was performed.