Repository navigation
Document current CLI behavior in English and Chinese and complete i18n checks - #2
Merged
Merged
Conversation
Extract CLI messages into locale catalogs; add language overrides, regression tests, CI, and bilingual documentation.
Preserve #1's current native adapters and canonical JSON behavior. Retain this branch's documentation, checker fixture tests, untrusted-path regression, and UTF-8 callback response language/length validation. Move detailed current Chinese scope into a usage guide and mirror current features in English. Local mise Rust 1.100.0: 129 tests passed, 2 existing isolated Secret Service checks ignored; 11 Python validator tests, fmt, all-target/all-feature Clippy -D warnings, catalog and source-package file checks passed.
LIghtJUNction
marked this pull request as ready for review
November 20, 2026 14:27
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This second i18n branch overlaps #1 and predates the current Pi/CC Switch implementation. Its old README would remove current adapter and credential-store details, and its localized JSON behavior conflicts with #1's stable machine-output contract.
Integration
Validation
Isolated development checkout, pinned mise Rust 1.100.0, Cargo jobs=1:
Published tree: 2d4d5964c5856eb0a0ceeb17285394b24f0de133, equal to the validated tree. Original branch history remains a parent of this resolution. No real account authorization, live credential-store acceptance, official application execution, model call, release or production change was performed.