Skip to content

Document current CLI behavior in English and Chinese and complete i18n checks - #2

Merged
LIghtJUNction merged 3 commits into
mainfrom
feat/i18n-readme-20261012
Nov 20, 2026
Merged

LIghtJUNction merged 3 commits into
mainfrom
feat/i18n-readme-20261012

Conversation

@LIghtJUNction

@LIghtJUNction LIghtJUNction commented Oct 11, 2026 •

Copy link
Copy Markdown
Member

Why

This second i18n branch overlaps #1 and predates the current Pi/CC Switch implementation. Its old README would remove current adapter and credential-store details, and its localized JSON behavior conflicts with #1's stable machine-output contract.

Integration

  • Base the resolution on merged Localize CLI presentation while preserving native adapter contracts #1, main 166bd76. Preserve current runtime behavior, 261-key catalogs, canonical JSON, native adapters and credential isolation.
  • Retain the unique English/Chinese documentation intent. Keep parallel concise READMEs, move the current detailed Chinese scope into a usage guide and supply an English counterpart. Describe current managed/native capabilities, Pi inspection, zbus/Secret Service, exact receipts, unknown outcomes and explicit limits.
  • Port the original 7 catalog-validator fixtures and add 4 missing cases: required files, unused keys and placeholder counts, catalog/key shape, and all runtime reference helpers.
  • Preserve the original callback-response improvement: fixed Content-Language and correct UTF-8 byte length, with the original cache/privacy headers and a regression test.
  • Preserve the untrusted-path regression for newline, ESC and placeholder-like path text.
  • Run the checker fixture suite in the existing validation workflow. Keep crates/package data consistent with both READMEs, catalogs and guide.

Validation

Isolated development checkout, pinned mise Rust 1.100.0, Cargo jobs=1:

  • Complete cargo test --locked: 129 passed, 0 failed; 2 existing opt-in isolated Linux Secret Service tests ignored.
  • scripts/test_i18n_checks.py: 11 passed.
  • 2 catalogs / 261 keys: values, placeholders and references passed.
  • rustfmt, all-target/all-feature Clippy -D warnings and diff --check passed.
  • cargo package --list --locked --allow-dirty passed; both locale files, both READMEs, the guide and checker scripts are included.
  • All local links in the five new/reworked documentation entry points resolve.

Published tree: 2d4d5964c5856eb0a0ceeb17285394b24f0de133, equal to the validated tree. Original branch history remains a parent of this resolution. No real account authorization, live credential-store acceptance, official application execution, model call, release or production change was performed.

Extract CLI messages into locale catalogs; add language overrides, regression tests, CI, and bilingual documentation.
Preserve #1's current native adapters and canonical JSON behavior. Retain this branch's documentation, checker fixture tests, untrusted-path regression, and UTF-8 callback response language/length validation. Move detailed current Chinese scope into a usage guide and mirror current features in English.

Local mise Rust 1.100.0: 129 tests passed, 2 existing isolated Secret Service checks ignored; 11 Python validator tests, fmt, all-target/all-feature Clippy -D warnings, catalog and source-package file checks passed.
@LIghtJUNction LIghtJUNction changed the title feat(cli): add English/Chinese i18n and refresh README Document current CLI behavior in English and Chinese and complete i18n checks Nov 20, 2026
@LIghtJUNction
LIghtJUNction marked this pull request as ready for review November 20, 2026 14:27
@LIghtJUNction
LIghtJUNction merged commit 755c986 into main Nov 20, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review ✅ Completed 2026-11-20T14:29:37.998155Z 1220226 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants