Skip to content

fix(ci): stabilize Python 3.15 quality and recovery checks - #247

Merged
LIghtJUNction merged 4 commits into
mainfrom
fix/python-quality-home-seo
Nov 20, 2026
Merged

LIghtJUNction merged 4 commits into
mainfrom
fix/python-quality-home-seo

Conversation

@LIghtJUNction

@LIghtJUNction LIghtJUNction commented Oct 23, 2026 •

Copy link
Copy Markdown
Member

Problem

Python 3.15 exposed three independent issues: Ruff/format drift in deploy/check_home_seo.py; pytest-asyncio's unset fixture-loop-scope warning becoming an error; and restored applications retaining a certificate validator bound to the pre-restore clock.

Changes

  • Apply the pinned Ruff import ordering/formatting and make the intentional retry counter explicit.
  • Configure the default async fixture loop scope and give the session-scoped async installation fixture a matching session loop.
  • Give CertificateValidator a forwarding clock so replacing Application.clock after restore takes effect immediately.
  • Integrate the current main, including fix(verification): reject symlinked source parent directories #248's fingerprint boundary protection, without changing these fixes or weakening assertions.

Original PR head: 70007351fe1872899b7c623b99169e88a47107a6.
Verified current base: c71a41d8b2b3601c63e734c344c8e58b5a52b676.
Integration head: 2c65570a10fe72a52464d2adcea06a4f64e31964.
Verified tree: bf8a2d0fa55529a0ca88191aa1858e58734cd77a.

Current development-machine validation — 2026-11-20

The exact combined tree was tested in an independent checkout, with Python 3.15.2, pytest 9.1.1, and pytest-asyncio 1.4.0.

  • .venv/bin/ruff check .: passed.
  • .venv/bin/ruff format --check .: passed.
  • .venv/bin/python -W error -m compileall -q src tests conformance scripts: passed.
  • .venv/bin/pytest -vv --tb=short tests/test_complete_recovery_proof.py tests/test_live_agent_space.py tests/test_internet.py: 48 passed, 0 failed, in 540.75 seconds.
  • The tests used a real, private PostgreSQL cluster, real backup/restore, and the test suite's local HTTP servers. No existing development or production database was used.
  • git diff --check and clean-source readback passed.
  • The local merge commit was d69f2111f1566dd825bb70a5b8ddf3c4bec4ccf6; the GitHub integration tree above is byte-for-byte identical.

Evidence: /home/lightjunction/Documents/GITHUB/pr-cleanup-org-20261120/evidence-msg/, including 10-full-disk.json, 10-full-disk.log, and the PostgreSQL log.

Preserved environment failures and their correction

Earlier attempts are retained as failures, not counted as acceptance:

  • An overlong Unix socket path prevented setup.
  • A scope constrained to 1 GiB was stopped by the kernel OOM handler after 33 successful tests.
  • A later attempt reached 29 passes but had five setup/teardown errors when PostgreSQL reported ENOSPC. The machine's /tmp is an 8 GiB tmpfs; only 508 MiB remained at diagnosis. Its 831.6 MiB scope peak distinguishes that failure from the earlier OOM.
  • Only this task's two completed temporary clusters were archived and removed, recovering about 1.1 GiB. The final successful run placed PostgreSQL data and pytest temporary files on the development disk, with only the short Unix socket directory in /tmp. The private cluster and test directories were cleaned by the task's own finalizer.

The Internet subset also passed all 15 tests independently before the complete 48-test run. No timeout, quality gate, assertion, or compatibility check in the repository was weakened. Registry-mirror-only lockfile churn was discarded; the original dependency lock was retained.

Scope

All 32 current workflow files were inspected for deployment consequences. They describe validation, including an isolated installed-wheel deployment rehearsal; this change does not invoke production deployment. No workflow was manually dispatched or rerun, and no release, tag, real account authorization, or live payment was performed. This targeted acceptance does not claim the entire repository's optional platform/integration matrix.

Copilot AI balanced review requested due to automatic review settings October 23, 2026 01:30

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review ✅ Completed 2026-10-23T01:34:05.428678Z 692ec85 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@LIghtJUNction LIghtJUNction changed the title fix(ci): satisfy Python quality gate fix(ci): stabilize Python 3.15 quality and recovery checks Oct 31, 2026

Copy link
Copy Markdown
Member Author

复核 2026-11-05 的当前状态:本 PR head 70007351fe1872899b7c623b99169e88a47107a6 关联的 13 个 workflow run、21 个 check run 均已完成且为 success;没有待处理的 inline review thread。

这里的 PR CI 已覆盖当前 main:Python quality 日志确认实际检出的是合成提交 5d3af6e01e72cfa33e04a07a0724b83cb6eac75a,即把该 head 合入 main@527dd3d4d7c8d66c09deb77f4910f5000c618fef。证据:quality job、完整 contracts、recovery、issue recovery。

当前 main 自身仍有四组失败:quality artifact 记录 deploy/check_home_seo.py 的 I001/B007/B904;两组 recovery 因未设置 asyncio_default_fixture_loop_scope 中止;contracts 的三个恢复用例报 certificate_expired。这些原因分别对应本 PR 的格式/异常链修正、显式 loop scope、动态 clock 转发。无需另开重复修复。

以上是现有 CI、产物和补丁的复核,没有重跑或修改代码。现有自动 review 摘要针对旧 head 692ec85,不能当作最新 head 的 review;也未执行批准、合并或部署。

… ci]

Preserve PR #248 fingerprint boundary changes. The combined tree passed all 48 recovery, live-agent-space and internet tests against an isolated disk-backed PostgreSQL cluster.
@LIghtJUNction
LIghtJUNction merged commit 446e206 into main Nov 20, 2026
LIghtJUNction added a commit that referenced this pull request Nov 20, 2026
…n [skip ci]

Source tree bf8a2d0 passed 48 real isolated PostgreSQL recovery/live-space/internet tests, Ruff, formatting and warnings-as-errors compilation. Preserve #248 and the original dependency lock. No deployment or release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants