Repository navigation
fix(verification): reject symlinked source parent directories - #248
Merged
Merged
Conversation
Member
Author
|
本 PR 正文中的“Full CI is pending”已有结果:head 已核对 quality artifact 的 source manifest(PR 合成提交 这项基线修复由 #247 跟踪,不应在这里重复实现。下一步是处理该依赖后更新分支,核验新的组合提交;保留 draft。本次只复核既有 CI 产物,没有重跑或改代码。 |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
LIghtJUNction
added a commit
that referenced
this pull request
Nov 20, 2026
… ci] Preserve PR #248 fingerprint boundary changes. The combined tree passed all 48 recovery, live-agent-space and internet tests against an isolated disk-backed PostgreSQL cluster.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
content_fingerprintrecords leaf symlinks without following them, but a tracked directory replaced by a symlink is still traversed when reading its tracked children. This can fingerprint files outside the checkout as verified source, contradicting the verifier's no-follow contract.Change
This is a static checkout guard, not a claim of race-proof traversal under concurrent hostile filesystem changes. No production access, credentials, deployment, or security settings changed.
Verification
pytest --noconftest -c /dev/null tests/test_local_verification.py tests/test_ci_shards.py -q.git diff --checkpassed.deploy/check_home_seo.pyissues already fixed independently in fix(ci): stabilize Python 3.15 quality and recovery checks #247. This PR deliberately does not duplicate that change.Base:
a97c9c40f08bb19846166fc057a2ae0dff2a81e6. Full CI is pending; keep draft.Maintenance validation — 2026-11-20
Revalidated fixed head
9946bc819ceff2ffdddabf5edbe7bc5ad76887d3for the authorized PR cleanup. The four executed Python source/test files were read from GitHub and their Git blob hashes verified before testing. With Python 3.12.14 and pytest 8.4.2, the unchanged standalone tooling suite passed 49/49 in 1.82 seconds:The first preparation attempt omitted the repository pyproject.toml: 48 passed and one setup case failed with FileNotFoundError. Adding that exact repository input yielded the complete pass above; neither source nor assertions changed. Current main
527dd3d4d7c8d66c09deb77f4910f5000c618fefonly adds README work after this PR's base, and the unaffected shard source/test blobs match exactly. This validates the isolated verification tooling, not the Python 3.15 application or production deployment. Per the current local-validation policy, no remote workflow was dispatched or awaited.