Skip to content

refactor: remove duplicate submission failure helper #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
XiaoCow666 merged 1 commit into from
Sep 19, 2026
Merged

refactor: remove duplicate submission failure helper #65

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions tasks/submission_tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ def refresh_student_learning_index(student_id):
return rebuild_student_vector_index(student_id)


def _mark_submission_failed(submission_id: int, message: str) -> None:
def mark_submission_failed(submission_id: int, message: str) -> None:
"""Mark one submission failed in the already-bound database."""

submission = db.session.get(Submission, submission_id)
Expand All @@ -116,12 +116,6 @@ def _mark_submission_failed(submission_id: int, message: str) -> None:
db.session.commit()


def mark_submission_failed(submission_id: int, message: str) -> None:
"""Expose the shared failure transition to submission entry points."""

_mark_submission_failed(submission_id, message)


def evaluate_submission_async(
app, submission_id, assignment_title, demo_run_id=None, *, run_inline=False
):
Expand All @@ -147,7 +141,7 @@ def evaluate_submission_async(
except SubmissionQueueUnavailable:
with app.app_context():
try:
_mark_submission_failed(
mark_submission_failed(
submission_id,
"提交评测队列暂时不可用，请稍后重试",
)
Expand Down Expand Up @@ -401,7 +395,7 @@ def _evaluate():
return
try:
db.session.rollback()
_mark_submission_failed(
mark_submission_failed(
submission_id,
"AI 评测失败，请稍后重试。" if demo_run_id else "后台评测发生严重错误，请稍后重试。",
)
Expand Down
Loading