Skip to content

style: use primary foreground color for widget titles - #149

Merged
robinvrd merged 1 commit into
mainfrom
robin/widget-title-primary-foreground
Nov 12, 2026
Merged

robinvrd merged 1 commit into
mainfrom
robin/widget-title-primary-foreground

Conversation

@robinvrd

Copy link
Copy Markdown
Contributor

Summary

  • Use the primary text token for shared widget headings so titles are easier to scan.
  • Keep widget counts and descriptions muted.

Verification

  • bun run build passed.
  • bun run check:styles passed.
  • git diff --check passed.
  • bun run check reached the test suite, where tests/public-api/dev-app.test.ts had 18 preview test failures; the run was stopped after those failures.

@robinvrd robinvrd changed the title Use primary foreground color for widget titles style: use primary foreground color for widget titles Nov 12, 2026
@albert20260301

Copy link
Copy Markdown

The CSS change keeps counts/descriptions muted as intended, and local build/style checks pass. The current required CI failure is the existing heading-color assertion: apps-dates.test.ts:61 still compares widget headings to muted table column headers (job log). I reproduced that single failure locally: primary rgb(32, 33, 36) versus muted rgb(104, 112, 120).

Update the test’s “muted typography” expectation to cover the intended primary heading color while retaining its shared typography and hierarchy checks, and keep coverage that counts/descriptions remain muted. Approval can follow once the required gate is green; no change to the intended title color is needed.

@robinvrd
robinvrd merged commit c33fd73 into main Nov 12, 2026
11 of 14 checks passed
@robinvrd
robinvrd deleted the robin/widget-title-primary-foreground branch November 12, 2026 16:42
francoischalifour added a commit that referenced this pull request Nov 16, 2026
#149 switched widget titles from `--atbl-muted` to `--atbl-text`, but
`tests/public-api/apps-dates.test.ts` still expected them to match the
muted table header color, so main's Check job has failed since. The test
now asserts the heading color resolves to `--atbl-text`; the
section-hierarchy assertions are unchanged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants