Repository navigation
style: use primary foreground color for widget titles - #149
Merged
Merged
Conversation
redox
approved these changes
Nov 12, 2026
|
The CSS change keeps counts/descriptions muted as intended, and local build/style checks pass. The current required CI failure is the existing heading-color assertion: Update the test’s “muted typography” expectation to cover the intended primary heading color while retaining its shared typography and hierarchy checks, and keep coverage that counts/descriptions remain muted. Approval can follow once the required gate is green; no change to the intended title color is needed. |
This was referenced Nov 16, 2026
francoischalifour
added a commit
that referenced
this pull request
Nov 16, 2026
#149 switched widget titles from `--atbl-muted` to `--atbl-text`, but `tests/public-api/apps-dates.test.ts` still expected them to match the muted table header color, so main's Check job has failed since. The test now asserts the heading color resolves to `--atbl-text`; the section-hierarchy assertions are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
bun run buildpassed.bun run check:stylespassed.git diff --checkpassed.bun run checkreached the test suite, wheretests/public-api/dev-app.test.tshad 18 preview test failures; the run was stopped after those failures.