Repository navigation
fix: rename from the provider's current name, so a renamed provider's CI passes - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scripts/rename.shhardcoded the template's name and skipped rewriting itself. So after the first rename it still renamed fromanolis-provider-template-python, and the second run failed. The "Rename still builds" CI job runs exactly that second rename in every provider made from the template, so every such provider went red right after following the README's step 2. Found by the outside instance, CameronBrooks11/anolis-provider-hello-python:The fix:
rename.shreads the current name frompyproject.toml's project name, so it renames from whatever the provider is called now.Verification
hello-python→renamed-check: both runs exit 0, no file names either earlier name, and format, lint, mypy and all 7 tests (harness included) pass.1ca8b57).