fix(arrow): return an owned slice from Schema.FieldsByName - #1069
Open
fallintoplace wants to merge 1 commit into
Open
fix(arrow): return an owned slice from Schema.FieldsByName#1069fallintoplace wants to merge 1 commit into
fallintoplace wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
For a unique name match,
Schema.FieldsByNamereturned a one-element slice backed by the schema’s internal field storage. Mutating the returned element could therefore mutate the schema. The duplicate-name path andSchema.Fieldsalready returned owned slices.Change
Return a new one-element slice for the unique-match path, making ownership consistent across all successful
FieldsByNameresults.Coverage
The regression test mutates the returned field and verifies that the original schema remains unchanged.
Validation
go test ./arrow