Skip to content

fix(arrow): return an owned slice from Schema.FieldsByName #1069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fallintoplace wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −1
Open

fix(arrow): return an owned slice from Schema.FieldsByName #1069

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion arrow/schema.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ func (sc *Schema) FieldsByName(n string) ([]Field, bool) {
return nil, ok
}
if len(indices) == 1 {
return sc.fields[indices[0] : indices[0]+1], ok
return []Field{sc.fields[indices[0]]}, ok
} else if len(indices) > 1 {
fields := make([]Field, 0, len(indices))
for _, v := range indices {
Expand Down
13 changes: 13 additions & 0 deletions arrow/schema_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,6 +336,19 @@ func TestSchema(t *testing.T) {
}
}

func TestSchemaFieldsByNameReturnsCopy(t *testing.T) {
schema := NewSchema([]Field{{Name: "id", Type: PrimitiveTypes.Int64}}, nil)
fields, ok := schema.FieldsByName("id")
if !ok {
t.Fatal("field not found")
}
fields[0].Name = "changed"

if got, want := schema.Field(0).Name, "id"; got != want {
t.Fatalf("schema field mutated through returned slice: got %q, want %q", got, want)
}
}

func TestSchemaAddField(t *testing.T) {
s := NewSchema([]Field{
{Name: "f1", Type: PrimitiveTypes.Int32},
Expand Down