Repository navigation
feat(biofeedback): BCIBiofeedback egress core (ADR-011) - #77
Merged
Merged
Conversation
Adds the outbound half of the Muse-to-DAW chain as a new target that depends on BCICore and BCIEEG only: per-channel band powers in physical units, a BiofeedbackFrame egress boundary, a deterministic health-gated FeatureMapper, a Mind Monitor-compatible OSC mirror, MIDI 1.0 events with UMP encoding, the BiofeedbackSink protocol with null/recording/ composite conformers, and the two transports (OSC/UDP, CoreMIDI virtual source) behind canImport. Promotes the test-only OSC encoder in MuseOSCDecoderTests to a production OSCEncoder in BCIEEG. Off by default; nothing is wired into AppContainer in this PR (follow-ups in OSC and CoreMIDI wiring PRs). Raw EEG never reaches a frame; the explicit raw toggle goes through MindMonitorMirror.rawEEG(_:) only. All 64 unit tests across BCIBiofeedbackTests (57) and OSCEncoderTests (7) compile and pass on M4 under Swift 6.0 alongside the full existing suite. Refs: ADR-011, decision_registry.md entry 10, ADR-004 (inbound OSC), PRINCIPLES.md 1, 3, 4, 5, 7.
5 tasks
Open
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the outbound half of the Muse-to-DAW chain as a new target that depends on
BCICoreandBCIEEGonly: per-channel band powers in physical units, aBiofeedbackFrameegress boundary, a deterministic health-gatedFeatureMapper, a Mind Monitor-compatible OSC mirror, MIDI 1.0 events with UMP encoding, theBiofeedbackSinkprotocol with null/recording/composite conformers, and the two transports (OSC/UDP, CoreMIDI virtual source) behindcanImport. Promotes the test-only OSC encoder inMuseOSCDecoderTeststo a productionOSCEncoderinBCIEEG.Off by default; nothing is wired into
AppContainerin this PR (follow-ups in OSC and CoreMIDI wiring PRs). Raw EEG never reaches a frame; the explicit raw toggle goes throughMindMonitorMirror.rawEEG(_:)only.Verification on M4 (Swift 6.0)
swift buildandswift testgreen on the M4 with the default (stub) configuration: all 64 PR 1 tests (10band power,11feature,20mapper,7MIDI,9mirror,7OSC encoder) and all pre-existing test suites (539tests total across 8 bundles) compiled and passed with 0 failures.BandPowerEstimatorTestspass with the stated tolerances (a 20 uV 10 Hz sinusoid reads 200 uV^2 +- 4 in alpha).BCI*target other thanNeuralComposeAppimportsBCIBiofeedback(grep).grep -rn "NWConnection(" Sources/returns onlyOSCUDPSender.swiftand the existing peer bridge.Refs: #76, ADR-011,
decision_registry.mdentry 10, ADR-004 (inbound OSC),PRINCIPLES.md1, 3, 4, 5, 7.