Repository navigation
test(gke): run the GKE suite through the Helm chart - #781
Open
gaurang-delavadiya wants to merge 1 commit into
Open
gaurang-delavadiya wants to merge 1 commit into
gaurang-delavadiya wants to merge 1 commit into
Conversation
Replace the hand-written DaemonSet manifests in terraform/gcp/gke with an install of the amazon-cloudwatch-observability Helm chart (k8sMode=GKE), and register the GKE suite in the test case generator so CI runs it from the generated matrix, like EKS and AKS. - terraform/gcp/gke: install the chart with default:otel, patch the agent image under test, keep the cluster, OIDC and IAM setup unchanged - Container Insights, Application Signals and container logs are disabled; the chart's fluent-bit has no GKE web-identity support yet - generator: add the gke test type and gke_test_matrix.json - The existing GKE Go test is reused unchanged
gaurang-delavadiya
marked this pull request as draft
October 9, 2026 09:56
gaurang-delavadiya
marked this pull request as ready for review
October 16, 2026 11:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the issue
The GKE suite added in #759 deploys the agent with a hand-written
default:otelDaemonSet and is not in the test case generator. EKS, and AKS with #780, install the agent through the amazon-cloudwatch-observability Helm chart and run from the generated matrix.Description of changes
terraform/gcp/gkeinstalls the chart withhelm_release(k8sMode=GKE,agent.config=default:otel), patches theAmazonCloudWatchAgentimage to the image under test, attaches the ECR pull secret to thecloudwatch-agentServiceAccount and restarts the agent. The cluster, IAM OIDC provider and IAM role setup are unchanged.helm_chart_branch(defaultmain) andhelm_set_values; thehelmandexternalproviders are added.gketest type andgenerator/resources/gke_test_matrix.json(e2-standard-4).TestGKEis unchanged.License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
terraform applyin a GCP project with chart branchmainand agent image7b574ef5:TestGKEPASS (Metrics, Logs, Traces); destroy completed with no leftover state.GenerateTestMatrixandGKEIntegrationTestscripts from ci: run GKE integration tests from the generated test matrix amazon-cloudwatch-agent#2343 were run locally against this branch, withterraform planin place of apply/destroy:gke_matrixfor eachtest_dir_filtervalue, chart branch resolution, and plan / plan -destroy pass.gofmt,terraform validateandterraform fmt -checkpass.Related pull requests
helm_chart_branchtoterraform/gcp/gke. This PR can merge independently:test_dirandhelm_chart_branchkeep defaults, so the #2299 job works with it as is.