Repository navigation
ci: run GKE integration tests from the generated test matrix - #2343
Open
gaurang-delavadiya wants to merge 1 commit into
Open
gaurang-delavadiya wants to merge 1 commit into
gaurang-delavadiya wants to merge 1 commit into
Conversation
Drive GKEIntegrationTest from gke_matrix in the test case generator, matching EKSIntegrationTest and AKSIntegrationTest, so new GKE suites only need a generator entry in the test repo. terraform/gcp/gke now installs the agent through the Helm chart. - GenerateTestMatrix outputs gke_matrix - Pass test_dir, the node machine type and the Helm chart branch (input, latest release-*, or main) to terraform/gcp/gke - Keep the Workload Identity Federation authentication and the GCE job as is
gaurang-delavadiya
force-pushed
the
convert-gke-tests-to-helm
branch
from
October 16, 2026 11:40
c0244aa to
a5cc299
Compare
gaurang-delavadiya
marked this pull request as ready for review
October 16, 2026 11:42
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the issue
#2299 adds
GKEIntegrationTestwith a fixed single-entry matrix. With aws/amazon-cloudwatch-agent-test#781, the GKE suite installs the agent through the Helm chart and is in the test case generator, like EKS and AKS (#2342).Description of changes
Builds on #2299 (its commits show here until it merges):
GenerateTestMatrixoutputsgke_matrixfromgke_complete_test_matrix.json.GKEIntegrationTestruns fromgke_matrix. The job name and WIP handling come from the matrix row, and it passestest_dir,gke_node_machine_type(frominstanceType) and the terraform directory from the row.release-*, elsemain) passeshelm_chart_branch, as the EKS job does.GCEIntegrationTestfrom ci: Add GCE and GKE integration test jobs #2299 are unchanged.License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
GenerateTestMatrixandGKEIntegrationTestscripts were run locally against test(gke): run the GKE suite through the Helm chart amazon-cloudwatch-agent-test#781, withterraform planin place of apply/destroy:gke_matrixfor'',./test/gcp/gke,./test/gcp/gceand unrelated filters; chart branch resolution and the input override; plan and plan -destroy. All pass.TestGKEpasses end to end with the same terraform variables (details in test(gke): run the GKE suite through the Helm chart amazon-cloudwatch-agent-test#781).actionlint: no new findings compared with ci: Add GCE and GKE integration test jobs #2299.Requirements
Workflow-only change;
make fmtandmake lintare not affected.Merge after #2299 and aws/amazon-cloudwatch-agent-test#781, which adds the
helm_chart_branchvariable this job passes. This PR and #2342 both add a matrix output toGenerateTestMatrix; whichever merges second needs a small rebase.Integration Tests
To run integration tests against this PR, add the
ready for testinglabel.