Repository navigation
doc: fix commit message template and drop build/ci types - #61
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0173PkNPTZf2uLFzoEzUuqVZ
This was referenced Aug 29, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
.gitmessage.txtdocumented a commit format this project does not use. It said:but every repository actually writes
type(scope): subject, which is whatCONTRIBUTING.mdspecifies and what 456 commits across the six repositories follow.This was not harmless. A contributor who opens the template and follows it writes a malformed subject line, gets it caught in review, and has to amend and force-push. That happened on launcher#10.
The same file is byte-identical in
byeol,launcher,stelaandindep, so all four carried the same wrong instructions. Companion PRs update the other three.Template changes
#<module>: <type>: <subject>#<type>(<scope>): <subject># Module is one of sub module like 'interp', 'seedling'# Scope is the module or area you touched, like 'core' or 'installer'.#test: interp: add new test case...#test(interp): add new test case...seedlingno longer exists, so the scope examples now name modules that do.The new paragraph says the subject line alone is usually enough and that long reasoning belongs in the PR description. The template previously said nothing about length, which is how a commit ended up carrying three paragraphs of design rationale that should have been here instead.
Type list: dropping
buildandciCONTRIBUTING.mdlisted nine types while the template listed seven. Rather than widen the template, this narrows the guide:buildandciare removed and those changes arechore.The example block also used
feat(ci):, which reads as thoughciwere a type. It is nowchore(ci):, so the example itself demonstrates thatciis a scope.Existing
build(...)andci(...)commits are left alone — 11 of them across the repositories. They are merged history and rewriting them buys nothing.Verification
Types in the template now match
CONTRIBUTING.mdexactly. Cross-checked against the last 300 commits in each of the six repositories: the seven types cover all but a handful of typos (docs,ffix,core), and scoped subjects outnumber bare ones 299 to 157.Only the first line of the template is not a comment, so nothing here leaks into a commit message body.
Merge order
This is the source of truth, so it should land before the three template-only PRs.
🤖 Generated with Claude Code
https://claude.ai/code/session_0173PkNPTZf2uLFzoEzUuqVZ