Skip to content

Fix web remote authentication, Git Review paths, and state recovery - #130

Merged
defia merged 1 commit into
chenbstack:mainfrom
S-huNsuke:codex/fix-review-and-recovery
Oct 14, 2026
Merged

defia merged 1 commit into
chenbstack:mainfrom
S-huNsuke:codex/fix-review-and-recovery

Conversation

@S-huNsuke

@S-huNsuke S-huNsuke commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

变更内容 / Summary

修复 Web Remote、Git Review 和存档恢复中的六项问题:

  • 浏览器拒绝明文授权和业务消息,禁止业务发送降级为明文,并隔离过期 WebSocket 事件。保留正常 challenge-response 认证与加密通信。
  • Git 文件列表和统计使用 NUL 分隔,确保中文、Tab、换行和引号文件名能正常查看 diff;明确关闭 rename detection,保持既有删除+新增表示及正确行数。修正 Bash/sh/zsh 的远端 Home 目录引用。
  • 恢复时修剪缺失 pane 引用并修复焦点;完全损坏的标签页补充可用终端;选择回退到现存工作区;pane 编号耗尽进入原有恢复流程,避免整数溢出崩溃。

补充回归测试,并将独立 Git/Swift 恢复校验纳入 CI。持久化 schema 不变。

验证方式 / Testing

  • 浏览器 42 项测试通过,包括 14 项新增认证链路测试,使用真实客户端和打包的 crypto 实现。
  • Git 23 项行为校验通过,使用真实临时 Git 仓库、生产 diff 代码和 Bash/sh/zsh。
  • 恢复 19 个场景通过,编译实际 Codable/Persistence 源码,以 CLT 轻量断言执行同源 XCTest 测试体。
  • 组合命令 node --test scripts/test-web-remote-*.mjs scripts/test-git-review.mjs scripts/test-persistence-recovery.mjs:44 个外层测试入口通过,0 失败(Git 和恢复脚本各算一个入口)。
  • Swift 5 语法解析、JavaScript 语法检查及 git diff --check 通过。

本机缺完整 Xcode 和 Ghostty 构建依赖,完整应用构建、XCTest runner 和真实 AppKit/Ghostty UI 未运行。原有完整 GlintTests CI 步骤保留。

截图或录屏 / Screenshots or recordings

暂无。本次为协议、文件路径和存档恢复逻辑修复;真实 UI 恢复后的分屏及焦点仍需完整开发环境验证。

关联议题 / Related issues

本次代码审查发现,未关联仓库 issue。

Reject plaintext business messages and prevent outbound encryption downgrade.
Preserve literal Git paths, align rename statistics, and fix SSH tilde quoting.
Repair stale pane layouts and workspace selections during state recovery.

Add browser, real Git/shell, and isolated Swift recovery regressions to CI.
Validation: 42 browser tests, 23 Git checks, and 19 recovery cases passed.
Swift/JavaScript syntax and diff checks passed. Full Xcode/UI validation was
not run because the local Xcode and Ghostty build dependencies are unavailable.

@defia defia left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已审查提交 7b53815:未发现需要修复的明确缺陷。浏览器 42 项、真实 Git 23 项及恢复 19 个场景的回归结果均通过,diff 检查通过。完整应用构建及真实 UI 验证尚未运行,需由 CI 和发布构建进一步确认。

@defia
defia merged commit 3df77e6 into chenbstack:main Oct 14, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants