Skip to content

[Fundamentals] Update manage members docs for new UI - #33563

Open
stechedo wants to merge 1 commit into
productionfrom
sdobeck/update-manage-members-ui
Open

stechedo wants to merge 1 commit into
productionfrom
sdobeck/update-manage-members-ui

Conversation

@stechedo

Copy link
Copy Markdown
Collaborator

Summary

Updates the Manage account members page and its partials for the new Members UI in the Cloudflare dashboard:

  • Add account members: rewritten for the new single-page invite flow — Invite members > Add email addresses > Add permission policies (scope picker with account-level and resource-specific scopes, role-name search, grouped role categories with select-all checkboxes) > Create policy (policies stack, repeatable) > Invite members. Invites send immediately; invitees show a Pending status.
  • Edit member permissions: new flow — member row ... > View & Edit permission policies > Permission policies tab (Create a policy, or per-policy ... > Edit policy / Delete policy).
  • Manage member settings (new section + new partial): documents the per-member API access control (Account default / Allow access / Block access) via ... > Manage member settings.
  • Resend an invitation: updated for the Pending status label and the ... > Resend invite path.
  • Remove account members: updated for ... > Remove member plus the confirmation dialog; notes the same path cancels a pending invitation.
  • manage.mdx: removed the Stream video embed (shows the old UI); updated the intro to reflect assigning multiple policies at invite time; updated the self-removal note (... > Leave account).
  • Bonus fixes: stray [ typo in view-account-members.mdx (visible on the live page); stale Invite label in email-security/migrate-to-email-security.mdx.

The AppSec learning path page (learning-paths/application-security/account-security/add-other-members.mdx) renders these same partials, so it inherits the updates.

Documentation checklist

@cloudflare-docs-bot

cloudflare-docs-bot Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Review

⚠️ 1 warning, 💡 2 suggestions found in commit 075a061.

👉 Fix in your agent 👈
Fix the following review findings in PR #33563 (https://github.com/cloudflare/cloudflare-docs/pull/33563).

Before making changes, review each finding and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g. the fix requires disproportionate effort for minimal benefit,
  or the finding is factually incorrect), explain why
- If you need clarification before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order

After triaging, follow this order:
1. Post a comment on this PR for any findings you are skipping, with the finding ID and your reasoning.
2. Then commit the fixes for the legitimate findings.

The comment must come before the commit — the bot reads PR comments when a new
push triggers a review, so skip comments posted after the push will be missed.

---

## Code Review

### Warnings (1)

#### CR-dfb3a92b3daa · Broken list numbering
- **File:** `src/content/partials/fundamentals/remove-account-members.mdx` line 15
- **Issue:** The rewrite replaced the old four-step list (1, 2, 3, 4) with a list numbered 1, 3, 4 — the former step 2 ("Locate an account member and expand their record.") was removed but the following steps were not renumbered, leaving no step 2 in the procedure.
- **Fix:** Renumber the steps to 1, 2, 3 so the list reads consecutively.

### Suggestions (1)

#### CR-03dbbe6af36f · Inconsistent ordered-list numbering
- **File:** `src/content/partials/fundamentals/add-account-members.mdx` line 15
- **Issue:** The procedure's list markers jump from `1.` (go to the Members page) to `3.` here, with no `2.` step in the source; the remaining steps are numbered 4–7. The rendered page auto-numbers so it displays correctly, but the source sequence suggests a step may have been dropped or the markers were copied from an older flow.
- **Fix:** Renumber this step to `2.` and shift the following steps (4–7) down accordingly, or confirm a step was intentionally removed, so the source markers match the intended procedure.

---

## Style Guide Review

### Suggestions (1)

#### SG-95d73b5af94c · Passive voice
- **File:** `src/content/docs/fundamentals/manage-members/manage.mdx` line 22
- **Issue:** Line 22: "Policies can also be added or revoked at a later time" uses passive voice where the actor ("you") is established in the preceding sentence.
- **Fix:** Rewrite in active voice for parallelism and clarity: "You can also add or revoke policies at a later time."

Code Review

This code review is in beta and may not always be helpful — use your judgment.

Warnings (1)
File Issue
partials/fundamentals/remove-account-members.mdx line 15 Broken list numbering — The rewrite replaced the old four-step list (1, 2, 3, 4) with a list numbered 1, 3, 4 — the former step 2 ("Locate an account member and expand their record.") was removed but the following steps were not renumbered, leaving no step 2 in the procedure. Fix: Renumber the steps to 1, 2, 3 so the list reads consecutively.
Suggestions (1)
File Issue
partials/fundamentals/add-account-members.mdx line 15 Inconsistent ordered-list numbering — The procedure's list markers jump from 1. (go to the Members page) to 3. here, with no 2. step in the source; the remaining steps are numbered 4–7. The rendered page auto-numbers so it displays correctly, but the source sequence suggests a step may have been dropped or the markers were copied from an older flow. Fix: Renumber this step to 2. and shift the following steps (4–7) down accordingly, or confirm a step was intentionally removed, so the source markers match the intended procedure.

Conventions

No convention issues found.

Style Guide Review

Suggestions (1)
File Issue
fundamentals/manage-members/manage.mdx line 22 Passive voice — Line 22: "Policies can also be added or revoked at a later time" uses passive voice where the actor ("you") is established in the preceding sentence. Fix: Rewrite in active voice for parallelism and clarity: "You can also add or revoke policies at a later time."
Commands

Only codeowners can run commands. Post a comment with the command to trigger it.

Command Description
/review Runs a review now. Incremental if a prior review exists, full if not.
/full-review Re-reviews the entire PR diff from scratch, ignoring incremental history. Useful after a rebase, when you want a fresh review, or if the bot gets out of sync and reports issues that no longer exist.
/ignore-review-limit Permanently lifts the 2-review automatic limit for this PR. Future pushes will trigger reviews as normal.
/disable-auto-review Stops automatic reviews from triggering on future pushes to this PR. Codeowners can still run /review or /full-review manually.
/rebase Rebases the PR branch against production. On conflict, attempts to resolve automatically using AI. Stops with an explanation if confidence is not high enough.

@cloudflare-docs-bot

cloudflare-docs-bot Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Review coverage

🟡 3 ownership areas need approval.

Suggested reviewers: @nikitacano @AdamBouhmad @mvvmm

Needs approval Eligible approvers Suggested
email-security @cloudflare/cf1-reviewers, @cloudflare/product-owners, @krystyna26 nikitacano
fundamentals
/src/content/docs/fundamentals/
@adambouhmad, @jhutchings1, @KaydeeDee, @sahidya, @cloudflare/product-owners adambouhmad
fundamentals
/src/content/partials/fundamentals/
@adambouhmad, @jhutchings1, @KaydeeDee, @sahidya, @cloudflare/product-owners mvvmm
CODEOWNERS mappings for displayed areas (3)
Pattern Owners
/src/content/docs/email-security/ @cloudflare/cf1-reviewers, @cloudflare/product-owners, @krystyna26
/src/content/docs/fundamentals/ @adambouhmad, @jhutchings1, @KaydeeDee, @sahidya, @cloudflare/product-owners
/src/content/partials/fundamentals/ @adambouhmad, @jhutchings1, @KaydeeDee, @sahidya, @cloudflare/product-owners

@cloudflare-workers-and-pages

Copy link
Copy Markdown

🚀 Deploying Preview to Cloudflare 🚀

Preview URL: https://sdobeck-update-manage-members-ui.previews.developers.cloudflare.com (commit 075a061)

This URL reflects your latest Preview deployment

Preview Deployments by commit

Status Deployment URL Commit Updated (UTC) See this deployment's details
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://8e492181.previews.developers.cloudflare.com 075a061 2026-09-21T13:30:35.870Z Visit the dashboard ↗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants