Skip to content

WC-5584 [wrangler] previews: fix wrangler-action missing worker_name #15761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
podonnell-dev merged 1 commit into from
Sep 22, 2026
+18 −10
Merged

WC-5584 [wrangler] previews: fix wrangler-action missing worker_name #15761

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/warm-cats-preview.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"wrangler": patch
---

Fix Preview output artifacts to always include the resolved parent Worker name

Preview artifacts now use Wrangler's resolved Worker name instead of relying on the Preview API response to include it.
1 change: 0 additions & 1 deletion packages/deploy-helpers/src/preview/api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@ export interface PreviewResource {
name: string;
slug: string;
urls?: string[];
worker_name: string;
tags?: string[];
observability?: Observability;
logpush?: boolean;
Expand Down
16 changes: 9 additions & 7 deletions packages/wrangler/src/__tests__/preview.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3075,7 +3075,7 @@ describe("wrangler preview", () => {
expect(std.warn).not.toContain("ASSETS");
});

test("should output preview and deployment JSON with --json", async ({
test("should output preview and deployment JSON for wrangler-action when the Preview API omits the Worker name", async ({
expect,
}) => {
const outputFile = "./output.json";
Expand Down Expand Up @@ -3103,7 +3103,6 @@ describe("wrangler preview", () => {
name: "test-preview",
slug: "test-preview",
urls: ["https://test-preview.test-worker.cloudflare.app"],
worker_name: "test-worker",
created_on: new Date().toISOString(),
},
},
Expand Down Expand Up @@ -3131,10 +3130,13 @@ describe("wrangler preview", () => {
)
);

await runWrangler("preview --name test-preview --json", {
...process.env,
WRANGLER_OUTPUT_FILE_PATH: outputFile,
});
await runWrangler(
"preview --name test-preview --worker-name override-worker --json",
{
...process.env,
WRANGLER_OUTPUT_FILE_PATH: outputFile,
}
);

expect(std.out).toContain('"preview"');
expect(std.out).toContain('"deployment"');
Expand All @@ -3150,7 +3152,7 @@ describe("wrangler preview", () => {
expect.objectContaining({
type: "preview",
version: 1,
worker_name: "test-worker",
worker_name: "override-worker",
preview_id: "preview-id-json",
preview_name: "test-preview",
preview_slug: "test-preview",
Expand Down
4 changes: 2 additions & 2 deletions packages/wrangler/src/preview/preview.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { preview } from "@cloudflare/deploy-helpers";
import { preview, resolveWorkerName } from "@cloudflare/deploy-helpers";
import { getWranglerTmpDir } from "@cloudflare/workers-utils";
import { getAssetsOptions } from "../assets";
import { getNormalizedContainerOptions } from "../containers/config";
Expand Down Expand Up @@ -135,7 +135,7 @@ export const previewCommand = createCommand({
writeOutput({
type: "preview",
version: 1,
worker_name: previewResource.worker_name,
worker_name: resolveWorkerName(args, previewConfig),
preview_id: previewResource.id,
preview_name: previewResource.name,
preview_slug: previewResource.slug,
Expand Down
Loading