Skip to content

WC-5584 [wrangler] previews: fix wrangler-action missing worker_name - #15761

Open
podonnell-dev wants to merge 1 commit into
mainfrom
podonnell/WC-5584-fix-wrangler-action-result
Open

podonnell-dev wants to merge 1 commit into
mainfrom
podonnell/WC-5584-fix-wrangler-action-result

Conversation

@podonnell-dev

@podonnell-dev podonnell-dev commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Fixes WC-5584.

Introducing previews support in wrangler-action revealed that we do not return worker_name reliably. This is an API schema gap since EWC explicitly does not return worker_name.

Addressing this in wrangler seems like the right move - we can simply compute this with existing functions


A picture of a cute animal (not mandatory, but encouraged)

@changeset-bot

changeset-bot Bot commented Sep 21, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 24659c5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
wrangler Patch
@cloudflare/vite-plugin Patch
@cloudflare/vitest-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ask-bonk

ask-bonk Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

LGTM

github run

@pkg-pr-new

pkg-pr-new Bot commented Sep 21, 2026

Copy link
Copy Markdown
@cloudflare/autoconfig

npm i https://pkg.pr.new/@cloudflare/autoconfig@15761

@cloudflare/build-output-utils

npm i https://pkg.pr.new/@cloudflare/build-output-utils@15761

@cloudflare/codemods

npm i https://pkg.pr.new/@cloudflare/codemods@15761

@cloudflare/config

npm i https://pkg.pr.new/@cloudflare/config@15761

@cloudflare/containers-shared

npm i https://pkg.pr.new/@cloudflare/containers-shared@15761

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@15761

@cloudflare/deploy-helpers

npm i https://pkg.pr.new/@cloudflare/deploy-helpers@15761

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@15761

miniflare

npm i https://pkg.pr.new/miniflare@15761

@cloudflare/pages-functions

npm i https://pkg.pr.new/@cloudflare/pages-functions@15761

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@15761

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@15761

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@15761

@cloudflare/vitest-plugin

npm i https://pkg.pr.new/@cloudflare/vitest-plugin@15761

@cloudflare/workers-auth

npm i https://pkg.pr.new/@cloudflare/workers-auth@15761

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@15761

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@15761

wrangler

npm i https://pkg.pr.new/wrangler@15761

commit: 24659c5

@podonnell-dev
podonnell-dev marked this pull request as ready for review September 21, 2026 20:04
@workers-devprod
workers-devprod requested review from a team and NuroDev and removed request for a team September 21, 2026 20:05
@workers-devprod

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • @cloudflare/wrangler
Show detailed file reviewers
  • .changeset/warm-cats-preview.md: [@cloudflare/wrangler]
  • packages/deploy-helpers/src/preview/api.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/preview.test.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/preview/preview.ts: [@cloudflare/wrangler]

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Untriaged

Development

Successfully merging this pull request may close these issues.

2 participants