feat: add Workers Previews support - #450
Open
podonnell-dev wants to merge 6 commits into
Open
podonnell-dev wants to merge 6 commits into
podonnell-dev wants to merge 6 commits into
Conversation
Open
5 tasks
ericclemmons
left a comment
ericclemmons
left a comment
Member
There was a problem hiding this comment.
Just had a couple questions before the lgtm stamp 🙏
ericclemmons
approved these changes
Sep 21, 2026
ericclemmons
left a comment
ericclemmons
left a comment
Member
There was a problem hiding this comment.
Thanks for addressing my comments ❤️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
wrangler previewsupport to the v4 action:--varinjection and stdout fallbackWORKERS_PREVIEWS_LIVEI'm unable to run the E2E test suite on a fork 😞 but local validation against binary mostly worked! I ended up catching a bug in our SDK response - we do not return worker_name (which this expects) so companion wrangler sdk PR is up: cloudflare/workers-sdk#15761
We'll want this to go in only after that is fixed