ci: wire npm run test:unit into CI - #116
Closed
mrbobbytables wants to merge 2 commits into
Closed
mrbobbytables wants to merge 2 commits into
mrbobbytables wants to merge 2 commits into
Conversation
Wire npm run test:unit into CI so PRs are validated before merge. Previously the only gate was deploy-gh-pages.yml, which runs on push to main after merge -- this allowed PR cncf#37 to merge with a syntactically broken scripts/validate-awards.mjs, only caught when the deploy workflow failed on main. Adds a pull_request + push-to-main triggered workflow that runs npm run test:unit, plus a node --check syntax gate over all scripts/**/*.mjs files as a cheap pre-test sanity check. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
hivecommons-hive
Bot
added
the
lgtm
![hivecommons-hive[bot]](https://avatars.githubusercontent.com/in/3568013?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Approved by @castrojo for Hive auto-merge on green CI.
Member
|
Automated triage update: the branch is now current with |
1 task
Member
|
Automated triage: closing as superseded by #175. The replacement is based on current |
mrbobbytables
added a commit
to mrbobbytables/endusers
that referenced
this pull request
Sep 21, 2026
…policy (cncf#206) Fleet strategist sweeps have repeatedly found duplicate PRs opening the same fix from different agents (issue cncf#119). All previously-flagged duplicate pairs in this repo (cncf#43/cncf#112, cncf#56/cncf#114, cncf#103/cncf#116) are already closed or merged, so the remaining actionable item is codifying the convention: search existing open/closed PRs before implementing a fix, link or supersede duplicates instead of opening parallel PRs, and reference existing tracking issues for workflow-file fixes instead of opening new artifact-patch PRs. Closes cncf#119 Signed-off-by: copilot-swe-agent <223556219+Copilot@users.noreply.github.com> Co-authored-by: copilot-swe-agent <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
.github/workflows/test.yml, apull_request(and push-to-main) triggered workflow that runsnpm ci+npm run test:unit, plus a cheapnode --checksyntax gate over allscripts/**/*.mjsfiles.Why
Closes #66. The only existing validation gate was
deploy-gh-pages.yml, which runs on push tomain— i.e. after merge. That's how #37 merged green with a syntactically brokenscripts/validate-awards.mjs: the pre-merge checks never ran the test suite, and the breakage was only caught when the deploy workflow failed on main (run 31236173766).Notes
actions/checkoutSHA already established inpdf.ymlfor consistency with existing security-conscious pinning in this repo.npm run test:unitpasses (53/53), andnode --checkpasses on all 9.mjsfiles underscripts/.Verification
npm run test:unit→ 53 passed, 0 failednode --checkon allscripts/**/*.mjsfiles → cleanChecklist