Repository navigation
test: cover ProjectsBorn full and compact rendered output - #479
Merged
Merged
Conversation
src/components/ProjectsBorn/index.js renders the full section embedded by docs/community and docs/practitioners, and the compact strip that src/theme/Footer ships on every page. Only the full form was ever executed, incidentally, as a module-resolution fixture in tests/jsx-hooks.test.mjs; the compact form was never rendered at all, leaving its four compact-gated branches and the title/intro prop overrides unguarded. tests/projects-born-render.test.mjs renders both forms through the existing helpers-jsx / react-element-tree harness and asserts the per-project anchor mapping, the prose blocks the compact form drops, the distinct heading ids behind aria-labelledby, the prop overrides, the aria-hidden arrow and the noreferrer pairing. This takes the component to 100% lines, branches and functions. Signed-off-by: kubestellar-hive[bot] <kubestellar-hive@hive.kubestellar.io>
Contributor
Author
|
Important Held for human review by the hive's ACMM level gate. This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the Hive will automatically remove the |
This was referenced Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Improvement
Adds
tests/projects-born-render.test.mjs. No production file changes.src/components/ProjectsBorn/index.jsrenders two different things from onecomponent: the full section embedded by
docs/community/index.mdanddocs/practitioners/index.md, and the compact strip thatsrc/theme/Footer/index.js:141renders as<ProjectsBorn compact />— onevery page of the site.
Before this PR, per-file isolation across every
tests/*.test.mjs(
node --test --experimental-test-coverage --test-coverage-include='src/components/ProjectsBorn/**')showed only two files touching the component:
tests/jsx-hooks.test.mjs@sitealias resolves; renders it as a fixture and asserts onlytree.type === 'section'tests/footer.test.mjscompact={true}; never renders the returned elementSo the compact form was never rendered, and nothing asserted the markup of
either form.
The new file renders both forms through the existing
tests/helpers-jsx.mjs/tests/tools/react-element-tree.mjsharness — the patterntests/cncf-project-card.test.mjsandtests/radar-reports.test.mjsalreadyuse — with 13 tests covering:
data/projects-born.jsonentry, in corpus order, in both formsaria-labelledbyresolving to anh2inside its own tree (a shared id would be ambiguous on a docs page that renders both)title/introprop overridesdocs/practitioners/index.md:72depends on, andintrobeing ignored whencompact↗stayingaria-hiddenrel="noreferrer"Result
up from
96.08 / 60.00 / 100.00with lines 13-14 uncovered.The assertions were mutation-checked, not just run: removing the
!compactguard on the intro paragraph fails
the compact strip drops the intro, descriptions and TAB footer noteandthe intro prop is ignored in the compact strip. The file isprettier --checkclean.Files claimed
tests/projects-born-render.test.mjs(new, the only file in this PR)Disjoint from every open PR: #435 (
ArchitectureFilters), #476(
pr-queue-hygiene), #225 (package.json+tests/tools/coverage-report.mjs),#195/#212/#266/#291 (import/validator/packaging). None touches
src/components/ProjectsBorn/**,tests/projects-born-*,tests/footer.test.mjsortests/jsx-hooks.test.mjs.Related Issue
Closes #478 — every box in that issue's task list is implemented here, and
merging leaves nothing further for it to track.
Filed by quality agent (hold-gated mode). Human review required.
— hive: agent=quality backend=copilot model=claude-opus-5