Repository navigation
test(bundle): drive handleIssueComment's prow-commands input arms and per-command error isolation through dist/index.js - #252
Conversation
|
Important Held for human review by the hive's ACMM level gate. This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the Hive will automatically remove the |
jeefy
left a comment
There was a problem hiding this comment.
This repeats handleIssueComment.test.ts, hold.test.ts:103/172 and remove.test.ts:28–100. The bundle tests already cover hold-alias removal (/unhold, bundle.test.ts:866) and /remove (:803).
- Keep only the missing/whitespace
prow-commandsinput cases and the "one failing command doesn't stop another" case. - Check error fragments (
.some(e => e.includes(...))) instead of pinning the fullTypeError: error handling issue comment: Error: …string in four places. - Use a shared config-read list and
comment()instead of copying them.
… per-command error isolation through dist/index.js Signed-off-by: quality <quality@hive.kubestellar.io>
aafa1cf to
6215491
Compare
|
Addressed all three: kept only the missing/whitespace 🐝 Hive Agent: — hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
|
#273 is merged: |
|
/kind cleanup |
Test Improvement
Adds
__tests__/bundle/dispatcherArms.test.tswith the threehandleIssueCommentarms the bundle suite did not reach:prow-commandsmissing → exit 1, error containsplease provide a list of space delimited commands / jobs to run, no api callprow-commandsof only whitespace → same (secondit.eachrow)/remove foo+/holdin one body with a non-collaborator →/removefails (commenter is not authorized to remove a label),/holdstill writes{ labels: ['do-not-merge/hold'] }, exit 1Errors are asserted as fragments (
errors.some(e => e.includes(...))), andcomment/repo/tokencome from the shared__tests__/bundle/helpers.ts. The unmatched-command, unsupported-name, alias,/remove-holdand/removeauthorization cases from the first revision were dropped on review (covered byhandleIssueComment.test.ts,hold.test.ts:103/172,remove.test.ts:28–100andbundle.test.ts:803/866).Verification on
main@ a270568:npx eslint,npx tsc --noEmit,npx vitest run __tests__/bundle/dispatcherArms.test.ts— 3 pass.Related Issue
Closes #251
Filed by quality agent (hold-gated mode). Human review required.