Skip to content

test(bundle): drive ok-to-test on pull_request synchronize and in the sweep through dist/index.js - #260

Merged
github-actions[bot] merged 1 commit into
mainfrom
quality/test-bundle-sweep-ok-to-test
Oct 3, 2026
Merged

github-actions[bot] merged 1 commit into
mainfrom
quality/test-bundle-sweep-ok-to-test

Conversation

@hivecommons-hive

@hivecommons-hive hivecommons-hive Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Test Improvement

Adds the two ok-to-test wiring cases dist/index.js was not driven through, inline in __tests__/bundle/bundle.test.ts:

  • pull_request owners-label and blunderbuss describe: synchronize of a pull request labelled ok-to-test → after owners-label and approve's probe, the runs waiting on its head are read and the action_required one is approved; tide skips synchronize. Reuses the shared routeOwners/ownersReads/ownersProbe.
  • schedule sweep job describe: a fork pr carrying ok-to-test → its pending run is approved before tide reads the pr and stops at the missing lgtm. Reuses that describe's forkPr/routeList/runSweep/listPage.

The separate sweepOkToTest.test.ts (13 cases, copied forkPr/routeList/routeOwnersLess/config-read list) was dropped on review: the other cases repeat sweep.test.ts:144–200, 454–490 and handlePullReq.test.ts:200, 228.

Verification on main @ a270568: npx eslint, npx tsc --noEmit, npx vitest run __tests__/bundle/bundle.test.ts — 90 pass (88 + 2).

Related Issue

Closes #259


Filed by quality agent (hold-gated mode). Human review required.

@hivecommons-hive
hivecommons-hive Bot requested a review from jpmcb as a code owner October 1, 2026 11:44
@hivecommons-hive hivecommons-hive Bot added the hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 1, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Important

Held for human review by the hive's ACMM level gate.

This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the outreach agent is always held because it publishes project-facing communication.

Hive will automatically remove the hold label once current policy no longer requires a level hold for "quality". If this is an outreach PR, a human must review it and remove the label.

@jeefy jeefy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only two cases are new to the bundle tests: ok-to-test on pull_request synchronize and in the sweep. The other ~11 repeat sweep.test.ts (144–200, 454–490) and handlePullReq.test.ts (200, 228).

  1. Trim to those two or three wiring cases.
  2. forkPr is a verbatim copy of bundle.test.ts:1824, and routeList, routeOwnersLess and the config-read list are copies too. Use shared helpers.

… sweep through dist/index.js

Signed-off-by: quality <quality@hive.kubestellar.io>
@hivecommons-hive
hivecommons-hive Bot force-pushed the quality/test-bundle-sweep-ok-to-test branch from c90add2 to 47730be Compare October 3, 2026 05:24
@hivecommons-hive hivecommons-hive Bot changed the title test(bundle): drive ok-to-test on pull_request and in the sweep, and the sweep's listing arms, through dist/index.js test(bundle): drive ok-to-test on pull_request synchronize and in the sweep through dist/index.js Oct 3, 2026
@hivecommons-hive hivecommons-hive Bot added agent/quality Created by Hive for agent-filed issue provenance hive/hosted-available-lke648397-260827-5q9t Created by Hive for agent-filed issue provenance labels Oct 3, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Addressed both: trimmed to the two wiring cases (synchronize + sweep), now inline in bundle.test.ts so they reuse the existing forkPr/routeList and the shared routeOwners/ownersReads; the separate file and its copies are gone. +34 lines net. Rebased on main @ a270568.


🐝 Hive Agent: quality | Instance: hosted-available-lke648397-260827-5q9t | SHA: 47730be

— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88

@jeefy

jeefy commented Oct 3, 2026

Copy link
Copy Markdown
Member

#273 is merged: __tests__/bundle/helpers.ts now exports repo, token, comment(), configReads(), ownersReads, ownersProbe, queueRead, membershipReads(), and via helpersFor(() => gh): calls(), expectRequests(), expectCommandThenConfig() and routeOwners(). Please rebase on main and import these instead of declaring local copies.

forkPr and routeList aren't in it yet (only one merged suite used them); move them into helpers.ts in this PR and import them from bundle.test.ts too, rather than copying. routeOwnersLess should become a routeOwners() call.

@jeefy jeefy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Asks addressed, thanks.

@jeefy

jeefy commented Oct 3, 2026

Copy link
Copy Markdown
Member

/kind cleanup
/lgtm
/approve
/hold cancel

@github-actions github-actions Bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed hold Indicates that a PR should not merge because someone has issued a /hold command. labels Oct 3, 2026
@github-actions
github-actions Bot merged commit 0194d4c into main Oct 3, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent/quality Created by Hive for agent-filed issue provenance hive/hosted-available-lke648397-260827-5q9t Created by Hive for agent-filed issue provenance kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[quality] the bundle e2e suite never drives ok-to-test on pull_request or in the sweep, nor the sweep's listing pagination and failure arms

1 participant