test(bundle): drive /reopen's and /retitle's collaborator-read 500 and refused-write arms through dist/index.js

[hivecommons-hive]

Test Improvement

Adds __tests__/bundle/collaborationArms.test.ts: three issue_comment runs through dist/index.js against the fake GitHub covering the /reopen and /retitle arms that collaborationCommands.test.ts leaves out —

• /reopen by a non-author, GET /collaborators/Codertocat → 500: exit 0, no PATCH, stdout carries ::warning::encountered unexpected error checking collaborator status: status=500 (src/utils/auth.ts checkCollaborator L98–101), followed by the authorization.close config reads feat(auth): opt-in authorization policy for label, hold, close and review commands #367 added after a refused collaborator check
• /reopen by the author, PATCH /issues/1 → 500: exit 1, ::error:: includes could not open issue (src/issueComment/reopen.ts L49)
• /retitle <title> by a collaborator, PATCH /issues/1 → 500: exit 1, ::error:: includes could not update issue (retitle.ts L57)

Imports comment, helpersFor, repo, token from ./helpers; no helper, source or dist/ changes. Files/functions claimed: __tests__/bundle/collaborationArms.test.ts only; reopen(), retitle(), checkCollaborator() failure arms. Disjoint from #283 (root-OWNERS / assertRootOwner), #296 (/close, /milestone) and #302 (/assign).

Measured on main @ 3fc21f2 with npm run test:coverage:e2e: reopen.ts 13 → 14 / 16 statements, auth.ts L98–101 now reached. The remaining lines (reopen.ts 21/36) are unreachable through the bundle (the payload always carries issue.number; checkCollaborator never throws) and stay unit-only.

Verified locally: npx eslint __tests__/bundle/collaborationArms.test.ts clean; npx vitest run __tests__/bundle/collaborationArms.test.ts → 3 passed; npm run test:coverage:e2e → 146 passed.

Review follow-up: the /retitle collaborator-500 case was dropped (collaborationCommands.test.ts:181 covers the non-collaborator /retitle, and retitle.ts L45 was not actually reached), and the suite now runs against current main.

Related Issue

Closes #305

---

Filed by quality agent (hold-gated mode). Human review required.

— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Important

Held for human review by the hive's ACMM level gate.

This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the outreach agent is always held because it publishes project-facing communication.

Hive will keep the hold label until a human removes it. Operators can make a deliberate one-off release during an ACMM level change with release_level_holds=true, but level changes never release this hold automatically.

[hivecommons-hive]

build-test red here is the shared incident tracked in #294, not this diff: run 37218349088 on b2465ba passes all 81 test files and exits 1 only on the single ERR_TLS_CERT_ALTNAME_INVALID unhandled error originating in __tests__/issueCommentTest/meow.test.ts; the twin run on the same SHA (37218322987) is green. The fix is #287. Deferring until #294 closes — no retries.

---

🐝 Hive Agent: quality | Instance: hosted-available-lke648397-260827-5q9t | SHA: 3fc21f2

— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88

[jeefy]

• Drop collaborationArms.test.ts:62–71. auth.ts:98–101 is already reached by :38, and /retitle by a non-collaborator is covered at collaborationCommands.test.ts:181. The PR body says this case reaches retitle.ts:45, but that line stays uncovered.

[hivecommons-hive]

Addressed: dropped the /retitle collaborator-500 case (and the body's retitle.ts:45 claim with it). The /reopen collaborator-500 case now also expects the authorization.close config reads that #367 added after the collaborator check refuses. Merged main too (it brings #287's meow network fix, which is what build-test was failing on).

---

🐝 Hive Agent: quality | Instance: hosted-available-lke648397-260827-5q9t | SHA: unknown

— hive: agent=quality backend=copilot model=claude-fable-5.1

[hivecommons-hive]

Addressed in 14a0932: dropped the /retitle collaborator-500 case; the PR body no longer claims retitle.ts:45.

CI is green on the new head.

---

🐝 Hive Agent: quality | Instance: hosted-available-lke648397-260827-5q9t | SHA: 1f7d33c

— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88

[jeefy]

Asks addressed; verified on current main (aa6a0f8) together with the other approved PRs.

[jeefy]

/kind cleanup
/lgtm
/approve
/hold cancel