Repository navigation
test(bundle): drive blunderbuss's ready_for_review skip, /auto-cc-on-issue, uncovered-file, no-candidate and refused-request arms through dist/index.js - #353
Merged
Conversation
…an issue, uncovered-file, no-candidate and refused-request arms through dist/index.js Adds __tests__/bundle/blunderbussArms.test.ts: five runs of the bundle against the fake GitHub covering the blunderbuss arms the bundle suite and blunderbussSettings.test.ts leave out: ready_for_review with ignore_drafts: false, /auto-cc on a plain issue, a changed file no OWNERS covers, an author who is the only reviewer, and a 500 on the reviewer request. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: quality <quality@hive.kubestellar.io>
Contributor
Author
|
Important Held for human review by the hive's ACMM level gate. This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the Hive will keep the |
Member
|
/kind cleanup |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Improvement
Adds
__tests__/bundle/blunderbussArms.test.ts: five runs throughdist/index.jsagainst the fake GitHub covering thesrc/plugins/blunderbuss.tsarms thatbundle.test.ts(defaults) and the held #291 (ignore_authors,exclude_approvers,max_request_count) leave out —pull_request ready_for_reviewwithignore_drafts: false: exit 0, stdoutblunderbuss: skipping ready_for_review action, noPOST …/requested_reviewers(blunderbuss.tsL101–102)/auto-ccon a plain issue: exit 0, stdoutblunderbuss: /auto-cc only applies to pull requests, no pull request read, no request (L118–119)openedwithREADME.mdchanged alongsidesdk/x.goand onlysdk/OWNERS: the uncovered file adds no candidates andbobalone is requested (L169)openedwhere the root OWNERS' only reviewer is the author: exit 0, stdoutblunderbuss: no reviewer candidates for #1, no request (L180–181)openedwithPOST …/requested_reviewers→ 500: exit 1,::error::includescould not request reviewers(L198)Imports
comment,helpersFor,repo,tokenfrom./helpers; no helper, source ordist/changes. Files/functions claimed:__tests__/bundle/blunderbussArms.test.tsonly;blunderbuss(),autoCc(),requestOwnersReviewers()skip/no-op/failure arms. Disjoint from #291 (blunderbussSettings.test.ts: L35, 159–161, 171, 186–189) and from every other held bundle PR, none of which drives blunderbuss. Line 94 (payload guard) stays unit-only: the fixture always carriespull_request.number.Measured on
main@ 3fc21f2 withnpm run test:coverage:e2e:blunderbuss.tse2e 77.77 → 88.88 % lines (56 → 64 / 72), 79.24 → 88.67 % branches; suite 142 → 147 tests passing. Unit (npm run test:coverage) already reports the file at 100 %.Verified locally:
npx eslint __tests__/bundle/blunderbussArms.test.tsclean;npx vitest run __tests__/bundle/blunderbussArms.test.ts→ 5 passed.Related Issue
Closes #352
Filed by quality agent (hold-gated mode). Human review required.
— hive: agent=quality backend=copilot model=claude-fable-5.1