Skip to content

test(bundle): drive blunderbuss's ready_for_review skip, /auto-cc-on-issue, uncovered-file, no-candidate and refused-request arms through dist/index.js - #353

Merged
github-actions[bot] merged 1 commit into
mainfrom
quality/test-blunderbuss-arms
Oct 7, 2026
Merged

github-actions[bot] merged 1 commit into
mainfrom
quality/test-blunderbuss-arms

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Test Improvement

Adds __tests__/bundle/blunderbussArms.test.ts: five runs through dist/index.js against the fake GitHub covering the src/plugins/blunderbuss.ts arms that bundle.test.ts (defaults) and the held #291 (ignore_authors, exclude_approvers, max_request_count) leave out —

  • pull_request ready_for_review with ignore_drafts: false: exit 0, stdout blunderbuss: skipping ready_for_review action, no POST …/requested_reviewers (blunderbuss.ts L101–102)
  • /auto-cc on a plain issue: exit 0, stdout blunderbuss: /auto-cc only applies to pull requests, no pull request read, no request (L118–119)
  • opened with README.md changed alongside sdk/x.go and only sdk/OWNERS: the uncovered file adds no candidates and bob alone is requested (L169)
  • opened where the root OWNERS' only reviewer is the author: exit 0, stdout blunderbuss: no reviewer candidates for #1, no request (L180–181)
  • opened with POST …/requested_reviewers → 500: exit 1, ::error:: includes could not request reviewers (L198)

Imports comment, helpersFor, repo, token from ./helpers; no helper, source or dist/ changes. Files/functions claimed: __tests__/bundle/blunderbussArms.test.ts only; blunderbuss(), autoCc(), requestOwnersReviewers() skip/no-op/failure arms. Disjoint from #291 (blunderbussSettings.test.ts: L35, 159–161, 171, 186–189) and from every other held bundle PR, none of which drives blunderbuss. Line 94 (payload guard) stays unit-only: the fixture always carries pull_request.number.

Measured on main @ 3fc21f2 with npm run test:coverage:e2e: blunderbuss.ts e2e 77.77 → 88.88 % lines (56 → 64 / 72), 79.24 → 88.67 % branches; suite 142 → 147 tests passing. Unit (npm run test:coverage) already reports the file at 100 %.

Verified locally: npx eslint __tests__/bundle/blunderbussArms.test.ts clean; npx vitest run __tests__/bundle/blunderbussArms.test.ts → 5 passed.

Related Issue

Closes #352


Filed by quality agent (hold-gated mode). Human review required.

— hive: agent=quality backend=copilot model=claude-fable-5.1

…an issue, uncovered-file, no-candidate and refused-request arms through dist/index.js

Adds __tests__/bundle/blunderbussArms.test.ts: five runs of the bundle
against the fake GitHub covering the blunderbuss arms the bundle suite and
blunderbussSettings.test.ts leave out: ready_for_review with
ignore_drafts: false, /auto-cc on a plain issue, a changed file no OWNERS
covers, an author who is the only reviewer, and a 500 on the reviewer
request.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: quality <quality@hive.kubestellar.io>
@hivecommons-hive hivecommons-hive Bot added the hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 6, 2026
@hivecommons-hive
hivecommons-hive Bot requested a review from jpmcb as a code owner October 6, 2026 16:50
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Important

Held for human review by the hive's ACMM level gate.

This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the outreach agent is always held because it publishes project-facing communication.

Hive will keep the hold label until a human removes it. Operators can make a deliberate one-off release during an ACMM level change with release_level_holds=true, but level changes never release this hold automatically.

@hivecommons-hive hivecommons-hive Bot added the hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 6, 2026
@jeefy

jeefy commented Oct 7, 2026

Copy link
Copy Markdown
Member

/kind cleanup
/lgtm
/approve
/hold cancel

@github-actions github-actions Bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed hold Indicates that a PR should not merge because someone has issued a /hold command. labels Oct 7, 2026
@github-actions
github-actions Bot merged commit 500595d into main Oct 7, 2026
13 checks passed
@mrbobbytables
mrbobbytables deleted the quality/test-blunderbuss-arms branch October 9, 2026 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[quality] blunderbuss's ready_for_review skip, /auto-cc-on-issue, uncovered-file, no-candidate and refused-request arms never run through dist/index.js

1 participant