Repository navigation
test(bundle): drive withdrawalReason's 'and N more' tail and no-withdrawer arm (approveReview.ts:105/120) through dist/index.js - #408
Merged
Conversation
…rawer arm (approveReview.ts:105/120) through dist/index.js The mirrored approve.github_review review's dismissal message truncates the uncovered-file list after five entries and only appends 'withdrawn by' when someone took an approval back. Neither arm was reached by the bundle suite: the existing short-circuit tests either return before withdrawalReason runs or always carry a /approve cancel comment and a single file. Add a bundle test that drives both through dist/index.js. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: quality <quality@hive.kubestellar.io>
hivecommons-hive
Bot
added
the
hold
Contributor
Author
|
Important Held for human review by the hive's ACMM level gate. This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the Hive will keep the |
Contributor
Author
|
/kind cleanup 🐝 Hive Agent: — hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
github-actions
Bot
added
kind/cleanup
This was referenced Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Improvement
Adds
__tests__/bundle/approveReviewReasonArms.test.ts(new file only; no existing test, helper or source file is touched), runningpull_request_reviewthroughdist/index.jsagainstfakeGithub.tswithapprove.github_review: true, theapprovedlabel set and the Bot's marker review present, for the two arms ofwithdrawalReason(src/plugins/approveReview.ts:104-120) the bundle suite never reached:/approve cancelby bob → the log names every file, the dismissal message is cut tono approver covers sdk/a.go, sdk/b.go, sdk/c.go, sdk/d.go, sdk/e.go and 2 more; withdrawn by bob (/approve cancel)(approveReview.ts:105)approved removed: no approver covers sdk/x.go, nowithdrawn bysuffix (approveReview.ts:120)Files/functions claimed:
__tests__/bundle/approveReviewReasonArms.test.ts(new) only;src/plugins/approveReview.tswithdrawalReasonlines 105 and 120. Disjoint from #333 (src/plugins/approve.tsarms) and fromapproveReviewShortCircuits.test.ts/approveReview.test.ts, which stay untouched.Verified locally on
main@ 20d49e7:npx vitest run __tests__/bundle/approveReviewReasonArms.test.ts(2 passed),npx eslintclean, andvitest --coverage --config vitest.e2e-coverage.config.mjs --coverage.reporter=jsonshows both branches on lines 105 and 120 at[1, 1].Related Issue
Closes #407
Filed by quality agent (hold-gated mode). Human review required.
— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88