Repository navigation
test(bundle): drive the lgtm removal no-op arms (onPrLgtm.ts:33, labels/lgtm.ts:106) through dist/index.js - #410
Merged
Conversation
…ls/lgtm.ts:106) through dist/index.js The pull_request lgtm job on a synchronize whose pull request carries no lgtm label, and /lgtm cancel when there is no commit binding to void (a pull request under lgtm.bind_to_commit: false, and a plain issue), had zero end-to-end hits: only the unit suite, with labeling mocked, pinned that they read the labels, remove nothing extra and never write a status. Closes #409 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: quality <quality@hive.kubestellar.io>
Contributor
Author
|
Important Held for human review by the hive's ACMM level gate. This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the Hive will keep the |
Contributor
|
Please add a kind label with |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Improvement
Adds
__tests__/bundle/lgtmRemovalNoopArms.test.ts, which drives throughdist/index.jsthe twolgtmremoval arms that unbind nothing:onPrLgtm.ts:33(else) —pull_requestsynchronizewithjobs: lgtmon a pull request labelledkind/bugonly: exit 0, the labels are read (GET /issues/1) after the registered handlers' OWNERS reads and base probe, and noDELETEis issued.labels/lgtm.ts:106(else) —/lgtm cancelwith no commit binding to void:lgtm:\n bind_to_commit: false:GET /issues/1,DELETE /issues/1/labels/lgtm, the configuration reads that find the binding off, then tide's post-command sweep (GET /pulls/1, base probe, queue read); noPOST /statuses/….lgtm: rootOWNERSprobe + membership reads,GET /issues/1,DELETE …/labels/lgtm, the sweep's configuration reads; no/pulls/read and noPOST.Evidence on
main@ 20d49e7: unit coverage is 100 % lines / 99.82 % branches (both arms green);npm run test:coverage:e2ewith the heads of all 15 open hold-gated bundle PRs merged showedonPrLgtm.ts:33ifhits[2, 0]andlabels/lgtm.ts:106ifhits[2, 0]. With this file they read[2, 1]and[2, 2].Files/functions claimed:
__tests__/bundle/lgtmRemovalNoopArms.test.tsonly;onPrLgtmno-label arm andcancelLgtm's no-binding arm. Disjoint from the open hold-gated PRs (#298 … #408), none of which touch these two branches — verified by merging all 15 heads ontomainand re-measuring. No production code is changed;npm run lintis clean on the new file.Related Issue
Closes #409
Filed by quality agent (hold-gated mode). Human review required.
— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88