[hivecommons-hive]

Test Improvement

Adds one scenario to __tests__/bundle/mergeGateLabels.test.ts driving loadTide's configured-tide.labels arm (src/plugins/tide.ts:542, config.tide.labels === undefined false) through the compiled dist/index.js, on a pull_request labeled event with tide:\n labels: [lgtm] in prow.yaml:

• [lgtm] on a base whose tree carries a root OWNERS → merged pr #1 (squash) and the tree is never read — the configured list replaces the [lgtm, approved] default

This is the "replaces the default list" / "skipped entirely when tide.labels is configured" promise in docs/automatic-merging.md:317-340 that was previously unit-only. The missing approved verdict is already covered by bundle.test.ts, and wildcard / case-insensitive matching goes through matchesLabelPattern, already driven by the missing_labels case in the same file.

Test-only change; no src/ or dist/ edits.

Related Issue

Refs #466

[hivecommons-hive]

Important

Held for human review by the hive's ACMM level gate.

This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the outreach agent is always held because it publishes project-facing communication.

Hive will keep the hold label until a human removes it. Operators can make a deliberate one-off release during an ACMM level change with release_level_holds=true, but level changes never release this hold automatically.

[github-actions]

Please add a kind label with /kind failing-test or /kind cleanup.

[jeefy]

All four cases reach only tide.ts:542's configured-tide.labels arm (genuinely new: mergeGateLabels.test.ts only configures missing_labels).

• Keep tideLabelsConfigured.test.ts:71–84 (a configured [lgtm] replaces the OWNERS default and the tree is never read). Drop :57–69 (missing approved is covered by bundle.test.ts:561) and :86–97/:99–110 (wildcard and case-insensitive matching go through matchesLabelPattern, driven by mergeGateLabels.test.ts:50).
• :1–55 copy mergeGateLabels.test.ts:1–48 almost line for line. Add the kept case to that file instead.

[mrbobbytables]

Addressed review: dropped the missing approved, wildcard and case-insensitive cases and the new file; the kept [lgtm]-replaces-default case now lives in mergeGateLabels.test.ts alongside the missing_labels case. Rebased on main.

[hivecommons-hive]

🔒 Hold-gate integrity: branch changed while hold-gated — fresh review required

This PR's branch moved while it sat hold-gated: the head recorded when the hold was applied was 7473883b8609, but the branch now sits at 1a4eb49e4a36. The diff a reviewer saw under the hold is no longer the diff that would merge, so auto-merge is blocked and the hold label has been re-applied.

Commits not present in the hold-time snapshot (1):

• 1a4eb49e4a36 by mrbobbytables — test(bundle): drive loadTide's configured tide.labels arm (tide.ts:542) through dist/index.js

Authors not in the hold-time author set: mrbobbytables

A human should review the FULL diff at the current head — a rebase or force-push renames every commit, so everything above needs eyes even if it looks familiar. Removing the hold label after that review is the fresh approval: the guard has re-pinned its snapshot to the current head, so a clean lift re-opens the merge lanes.

Dismissing stale review: the PR was revised after this review (commit post-dates it) and now implements the requested restructuring (single case, folded into the existing test file, fixture adjusted). Stack of #467–#482 verified locally: 78 bundle files / 481 tests pass, eslint clean.