fix: schedule subject mapper - #14
Merged
Merged
Conversation
The isCanceled/group.isNotEmpty filter and Subject->ScheduleSubject mapping was business logic inlined in the viewmodel's build(). Pulled it into presentation/utils/schedule_subject_mapper.dart, following the same pattern as schedule_day_agenda.dart, so the viewmodel is back to pure orchestration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Descripción
ScheduleViewModel.build()tenía embebida una regla de negocio (filtrar materias canceladas o sin grupo asignado y mapearlas aScheduleSubject) directamente en el ViewModel, en vez de vivir en una capa testeable y reutilizable.NewsViewahora soporta pull-to-refresh (RefreshIndicator), y elAppScaffold/lista vacía de noticias se ajustaron para que el scroll siempre sea posible (necesario para que el refresh funcione incluso con lista vacía).Tipo de cambio
¿Cómo se ha probado esto?
Checklist
Screenshots (si aplica)
Comentarios adicionales