Skip to content

fix(lint): exclude playwright-report/ and test-results/ from eslint - #27

Open
ericgozzi wants to merge 1 commit into
mainfrom
fix/eslint-ignore-playwright-artifacts
Open

ericgozzi wants to merge 1 commit into
mainfrom
fix/eslint-ignore-playwright-artifacts

Conversation

@ericgozzi

Copy link
Copy Markdown
Collaborator

Summary

  • `eslint.config.js`'s top-level `ignores` list didn't mirror `.gitignore`'s `playwright-report/` and `test-results/` entries.
  • Once either directory exists locally (e.g. after running `npm run test:browser`), `npm run lint` - and therefore `npm run check` - picks up ~4000 errors from Playwright's bundled/minified vendor JS inside the report.
  • Unrelated to the in-flight toolbar-schema work; found while investigating a report of `npm run check` failing with thousands of errors.

Test plan

  • Reproduced: with a local `playwright-report/` present, `npx eslint .` failed with ~3981 errors before this fix.
  • `npx eslint . --max-warnings=0` passes clean after the fix, with the same `playwright-report/` still present.

Both are gitignored, Playwright-generated output directories, but eslint's own
ignores list didn't mirror .gitignore for them. Once a local playwright-report/
exists (e.g. after running the browser test suite), npm run lint - and therefore
npm run check - picks up thousands of errors from its bundled/minified vendor JS.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant