Conversation
Cherry-picked from f3e5c3c, narrowed to the part still applicable here: scripts/test-package.mjs's spawnSync calls for npm.cmd needed shell: true on Windows (Node can't exec a .cmd shim without going through a shell), so the script has never actually run to completion locally on Windows until now. f3e5c3c's other change - making scripts/prepare.mjs capture the build's stdout instead of inheriting it, so it can't corrupt npm pack --json's own --json output - does not apply on top of origin/main: prepare.mjs no longer exists there, having been replaced by a `git config core.hooksPath .githooks` prepare step that doesn't build at all and so can't hit this problem in the first place. That part is intentionally left out as moot. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/test-package.mjscallsspawnSynconnpm.cmd, which needsshell: truebecause Node can't run a.cmdshim without a shell. Until now,npm run test:packagenever ran to completion locally on Windows.f3e5c3c(onfeature/bidirectional-sync), keeping only the part that still applies. That commit's other change, toscripts/prepare.mjs, doesn't matter anymore becauseprepare.mjsno longer exists onmain.Node 22+ prints a
DEP0190warning forshell: truewith an args array. It's harmless here because the args are fixed, but it could be rewritten as one command string later.Stacked on #27 (eslint ignore for Playwright artifacts). Stack: #27 → this → #32 (frame-budgeted drain) → #33 (center geometry).
Test plan
npm run test:packagepasses locally on Windows🤖 Generated with Claude Code