Skip to content

fix(ci): pass shell: true so test:package can spawn npm.cmd on Windows #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ericgozzi wants to merge 1 commit into from
Open

fix(ci): pass shell: true so test:package can spawn npm.cmd on Windows #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions scripts/test-package.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,10 @@ function run(command, args, options = {}) {
}

try {
// shell: true - required on Windows to spawn a .cmd shim (npm.cmd) at all;
// Node's spawnSync can't exec one directly without going through a shell.
// Safe here specifically because these args are internally generated
// (this repo's own paths and fixed flag strings), never user input.
const packed = JSON.parse(
run(
npmCommand,
Expand All @@ -47,7 +51,7 @@ try {
"--pack-destination",
consumerRoot,
],
{ cwd: projectRoot },
{ cwd: projectRoot, shell: true },
),
);
const archive = join(consumerRoot, packed[0].filename);
Expand All @@ -60,7 +64,7 @@ try {
type: "module",
}),
);
run(npmCommand, ["install", "--ignore-scripts", archive]);
run(npmCommand, ["install", "--ignore-scripts", archive], { shell: true });

const packageName = "@compas-dev/compas-threejs-ts";
const installed = JSON.parse(
Expand Down
Loading