fix(ui): a slider gutter you can actually see, and no Debug tab in the show UI - #124
Merged
Merged
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The slider gutter was invisible regardless of colour, and the fix in #122 couldn't have worked. The track was painted on the input itself:
Any slider whose height was under the 16px of padding — the default, and the inline
height: 24/28overrides — rendered no track at all. Painting the gutter on::-webkit-slider-runnable-track/::-moz-range-trackinstead decouples the visible channel from the element's height, so the element height is purely the touch target and components can override it freely. The thumb getsmargin-top: -11pxto stay centred on the thinner track (-12pxat the coarse-pointer size). Colour is#1c2b4d— the panel stays black, only the channel lifts off it.Also drops the
debugtab from the show UI (debugging lives in the desktop shell now), which leavesSettingsTabunreferenced, so it's deleted along with the'debug'member ofGridModeand the tab-change calibration teardown that existed only for it. Tab strip padding and pill padding come in a couple of px.Link to Devin session: https://app.devin.ai/sessions/ec43152136134467a853ec0bbf783ea9
Requested by: @pyramation