Skip to content

fix(ui): a slider gutter you can actually see, and no Debug tab in the show UI #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pyramation merged 1 commit into from
Aug 19, 2026
Merged

fix(ui): a slider gutter you can actually see, and no Debug tab in the show UI #124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 4 additions & 18 deletions packages/ui/src/app.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ import { PatternsTab } from '@/components/patterns-tab';
import { PlaylistTab } from '@/components/playlist-tab';
import { PrideTab } from '@/components/pride-tab';
import { SequencesTab } from '@/components/sequences-tab';
import { SettingsTab } from '@/components/settings-tab';
import { ShiftDial } from '@/components/shift-dial';
import { StatusDot } from '@/components/status-dot';
import { UsaTab } from '@/components/usa-tab';
Expand Down Expand Up @@ -59,8 +58,7 @@ const tabs: { key: GridMode; label: string }[] = [
{ key: 'flags', label: 'Flags' },
{ key: 'drops', label: 'Drops' },
{ key: 'audio', label: 'Audio' },
{ key: 'video', label: 'Video' },
{ key: 'debug', label: 'Debug' }
{ key: 'video', label: 'Video' }
];

/* ---------- Tool content (no tabs, just the active tool) ---------- */
Expand Down Expand Up @@ -293,13 +291,6 @@ function ToolContent({
<VideoTab send={send} numCannons={numCannons} gridColumns={gridColumns} />
)}

{tab === 'debug' && (
<SettingsTab
numCannons={numCannons}
gridColumns={gridColumns}
send={send}
/>
)}
</>
);
}
Expand All @@ -322,7 +313,7 @@ function TabStrip({
<div
className={isRight ? 'flex flex-wrap gap-1 shrink-0' : 'flex gap-1 overflow-x-auto shrink-0'}
style={{
padding: isRight ? '10px 10px 6px' : '8px 12px 6px',
padding: isRight ? '8px 10px 5px' : '6px 12px 5px',
...(isRight ? {} : { WebkitOverflowScrolling: 'touch' as const })
}}
>
Expand All @@ -332,8 +323,8 @@ function TabStrip({
onClick={() => setTab(t.key)}
className="whitespace-nowrap transition-all"
style={{
padding: isPhone ? '10px 16px' : isRight ? '8px 12px' : '10px 18px',
borderRadius: 22,
padding: isPhone ? '9px 14px' : isRight ? '7px 11px' : '8px 15px',
borderRadius: 20,
fontSize: isPhone ? 14 : isRight ? 12 : 14,
fontWeight: 600,
letterSpacing: '0.02em',
Expand Down Expand Up @@ -593,7 +584,6 @@ export default function Home() {
}, [settings]);

useEffect(() => {
if (tab === 'debug') return;
send({ type: 'physical_preview_clear' });
send({ type: 'calibration_mode', enabled: false });
}, [send, tab]);
Expand Down Expand Up @@ -826,10 +816,6 @@ export default function Home() {
);

const handleTabChange = useCallback((t: GridMode) => {
if (t !== 'debug' && tab === 'debug') {
send({ type: 'physical_preview_clear' });
send({ type: 'calibration_mode', enabled: false });
}
setTab(t);
localStorage.setItem('wavegrid-tab', t);
if (isPhone && sheetSnap === 'peek') {
Expand Down
2 changes: 1 addition & 1 deletion packages/ui/src/components/grid-display.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { useCallback, useEffect, useRef } from 'react';

import type { CannonColor, Orientation } from '@/lib/use-socket';

export type GridMode = 'paint' | 'gradient' | 'drops' | 'scenes' | 'animations' | 'audio' | 'video' | 'flags' | 'pride' | 'usa' | 'nova' | 'grace' | 'patterns' | 'playlist' | 'sequences' | 'debug';
export type GridMode = 'paint' | 'gradient' | 'drops' | 'scenes' | 'animations' | 'audio' | 'video' | 'flags' | 'pride' | 'usa' | 'nova' | 'grace' | 'patterns' | 'playlist' | 'sequences';

export interface FixturePos {
u: number;
Expand Down
Loading
Loading