Repository navigation
Jackson 2.22 compatibility: replace removed PropertyNamingStrategy.SNAKE_CASE - #37
Closed
engrams-agent[bot] wants to merge 4 commits into
Closed
engrams-agent[bot] wants to merge 4 commits into
engrams-agent[bot] wants to merge 4 commits into
Conversation
…_CASE Jackson 2.20 removed the deprecated PropertyNamingStrategy constants. Use PropertyNamingStrategies.SNAKE_CASE (available since 2.12) instead. Bump jackson-databind 2.14.0 -> 2.22.2 and version 1.329 -> 1.330. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The deploy job failed: setup-java@v2 cache on Java 8 returned 400, and the workflow only granted contents:read so mvn deploy could not publish. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The fork's distributionManagement points at GitHub Packages (id=github), but upstream's nexus-staging-maven-plugin was still present and injects its own deploy goal requiring sonatype-nexus-staging credentials. Remove it so mvn deploy uses the standard deploy plugin against GitHub Packages. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This was referenced Nov 3, 2026
akwirick
added a commit
that referenced
this pull request
Nov 4, 2026
Changes: - Replaced the removed PropertyNamingStrategy.SNAKE_CASE with PropertyNamingStrategies.SNAKE_CASE in GitHubClient - Bumped jackson-databind to 2.21.8 - Set the version to 1.331, since unmerged #37 already published 1.330 - Gated the deploy job to pushes on main, so pull request runs stop publishing Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
|
🤖 Superseded by #39 (merged). |
This was referenced Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Jackson 2.20 removed the deprecated
PropertyNamingStrategyconstants (includingSNAKE_CASE). The fork pinned at1.329still referencesPropertyNamingStrategy.SNAKE_CASEinGitHubClient.<clinit>, which throwsNoSuchFieldErrorat runtime when the consuming app (cortexapps/brain-backend) upgrades to Jackson 2.22.Changes
GitHubClient.java:PropertyNamingStrategy.SNAKE_CASE→PropertyNamingStrategies.SNAKE_CASE(available since Jackson 2.12, so this stays compatible with older Jackson too).pom.xml:jackson-databind2.14.0 → 2.22.2.pom.xml: version 1.329 → 1.330.Why
Unblocks the Jackson 2.18→2.22 upgrade in cortexapps/brain-backend (Dependabot PR #16943), which depends on
org.kohsuke:cortexapps-github-api.Merging this publishes
1.330to GitHub Packages via the existingdeployjob.🤖 Generated with Claude Code